Upgrade AWS-SDK #7307
Merged
Upgrade AWS-SDK #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Dependencies
guikcd
force-pushed
the
aws_sdk_upgrade
branch
from
ed43386
to
9f95da4
Compare
|
Also noticed #7297, need to check |
guikcd
force-pushed
the
aws_sdk_upgrade
branch
from
9f95da4
to
ed6e6c0
Compare
guikcd
force-pushed
the
aws_sdk_upgrade
branch
from
ed6e6c0
to
226b035
Compare
blackpiglet
previously approved these changes
Jan 15, 2024
guikcd
force-pushed
the
aws_sdk_upgrade
branch
from
226b035
to
2f3d901
Compare
|
I fixed go.sum file. |
|
Please take a look at the CI failures. |
Signed-off-by: Guillaume Delacour <delacoug@amazon.com>
guikcd
force-pushed
the
aws_sdk_upgrade
branch
from
2f3d901
to
373b24e
Compare
|
aws-sdk-go v2 introduced on some services a breaking change: https://github.com/aws/aws-sdk-go-v2/blob/release-2023-11-17/feature/s3/manager/CHANGELOG.md#v1140-2023-11-17 I've fixed it: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7307 +/- ##
==========================================
+ Coverage 61.76% 61.77% +0.01%
==========================================
Files 262 262
Lines 28440 28440
==========================================
+ Hits 17567 17570 +3
+ Misses 9642 9640 -2
+ Partials 1231 1230 -1 ☔ View full report in Codecov by Sentry. |
blackpiglet
approved these changes
Jan 17, 2024
shubham-pampattiwar
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
AWS EKS Pod Identity requires aws-sdk v2 version bumped (not sure why dependabot don't propose the upgrade as other modules):
Source
Does your change fix a particular issue?
No
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.