Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. #7380

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Feb 2, 2024

  • Simplify comments

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7292

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2f25c25) 61.65% compared to head (423d63d) 61.61%.

Files Patch % Lines
pkg/controller/backup_repository_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7380      +/-   ##
==========================================
- Coverage   61.65%   61.61%   -0.04%     
==========================================
  Files         262      262              
  Lines       28479    28482       +3     
==========================================
- Hits        17558    17550       -8     
- Misses       9689     9699      +10     
- Partials     1232     1233       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai kaovilai force-pushed the restic-recreate-repo branch 4 times, most recently from 044efef to fc68cb7 Compare February 5, 2024 22:20
@kaovilai kaovilai marked this pull request as ready for review February 5, 2024 22:20
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title Fix backupRepository (restic) can become stale after bsl recreate BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. Feb 5, 2024
sseago
sseago previously approved these changes Feb 5, 2024
@kaovilai
Copy link
Contributor Author

kaovilai commented Feb 6, 2024

found a way to simplify..

Lyndon-Li
Lyndon-Li previously approved these changes Feb 6, 2024
@Lyndon-Li
Copy link
Contributor

@kaovilai Please fix the CI problems. The current code looks good to me.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
Copy link
Contributor Author

kaovilai commented Feb 6, 2024

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

just need someone to rerun codecov upload

@sseago sseago merged commit a5c72a4 into vmware-tanzu:main Feb 6, 2024
22 of 24 checks passed
kaovilai added a commit to kaovilai/velero that referenced this pull request Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/velero that referenced this pull request Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/velero that referenced this pull request Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/velero that referenced this pull request Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/velero that referenced this pull request Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Lyndon-Li added a commit that referenced this pull request Feb 20, 2024
release-1.12: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380)
Lyndon-Li added a commit that referenced this pull request Feb 20, 2024
release-1.13: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backupRepository (restic) can become stale after bsl recreate
3 participants