Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support certificate-based authentication for Azure #7549

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ywk253100
Copy link
Contributor

Support certificate-based authentication for Azure

Fixes #6735

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Support certificate-based authentication for Azure

Fixes vmware-tanzu#6735

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.68%. Comparing base (6ec1701) to head (4c95edd).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/util/azure/credential.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7549      +/-   ##
==========================================
+ Coverage   61.65%   61.68%   +0.03%     
==========================================
  Files         263      263              
  Lines       28680    28829     +149     
==========================================
+ Hits        17682    17784     +102     
- Misses       9753     9787      +34     
- Partials     1245     1258      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshulahuja98
Copy link
Collaborator

PR LGTM
We can perhaps add docs example when we take these changes to azure plugin for consumption.

@ywk253100 ywk253100 merged commit cd0632c into vmware-tanzu:main Mar 27, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Azure Service Principal Certificate-Based authentication
3 participants