Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track and persist restore volume info #7630

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

reasonerjt
Copy link
Contributor

@reasonerjt reasonerjt commented Apr 8, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7546

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@reasonerjt reasonerjt force-pushed the restore-vol-info branch 2 times, most recently from c1ad8ba to 077b5a4 Compare April 8, 2024 07:41
@reasonerjt reasonerjt marked this pull request as draft April 8, 2024 07:44
@reasonerjt reasonerjt force-pushed the restore-vol-info branch 4 times, most recently from 5c05779 to 3fc8afb Compare April 9, 2024 05:57
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 61.78%. Comparing base (500e5ae) to head (0a280e5).

Files Patch % Lines
internal/volume/volumes_information.go 76.78% 49 Missing and 3 partials ⚠️
pkg/cmd/util/output/backup_describer.go 40.00% 9 Missing ⚠️
pkg/controller/restore_controller.go 76.00% 3 Missing and 3 partials ⚠️
pkg/persistence/object_store.go 33.33% 4 Missing ⚠️
pkg/cmd/util/output/backup_structured_describer.go 66.66% 3 Missing ⚠️
pkg/label/label.go 0.00% 2 Missing ⚠️
pkg/persistence/object_store_layout.go 0.00% 2 Missing ⚠️
pkg/cmd/server/server.go 0.00% 1 Missing ⚠️
pkg/restore/restore.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7630      +/-   ##
==========================================
+ Coverage   61.25%   61.78%   +0.53%     
==========================================
  Files         276      277       +1     
  Lines       31325    24895    -6430     
==========================================
- Hits        19187    15382    -3805     
+ Misses      10784     8153    -2631     
- Partials     1354     1360       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reasonerjt reasonerjt force-pushed the restore-vol-info branch 2 times, most recently from fa35d19 to 533b8db Compare April 9, 2024 09:22
@github-actions github-actions bot added Website non-docs changes for the website has-changelog labels Apr 9, 2024
@reasonerjt reasonerjt force-pushed the restore-vol-info branch 4 times, most recently from 018c818 to 3fc9be7 Compare April 11, 2024 09:22
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt reasonerjt changed the title [WIP] Track and persist restore volume info Track and persist restore volume info Apr 11, 2024
@reasonerjt reasonerjt marked this pull request as ready for review April 11, 2024 10:03
@ywk253100 ywk253100 merged commit 3c377bc into vmware-tanzu:main Apr 12, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog has-unit-tests Website non-docs changes for the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce volume-info metadata for restore to track the restore of PV/PVC
3 participants