Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific credential rather than the credential chain for Azure #7680

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ywk253100
Copy link
Contributor

Use specific credential rather than the credential chain for Azure

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (0e55363) to head (40b0683).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7680      +/-   ##
==========================================
+ Coverage   58.15%   58.42%   +0.27%     
==========================================
  Files         343      343              
  Lines       35770    28380    -7390     
==========================================
- Hits        20801    16581    -4220     
+ Misses      13552    10386    -3166     
+ Partials     1417     1413       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use specific credential rather than the credential chain for Azure

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Copy link
Collaborator

@anshulahuja98 anshulahuja98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for driving this. This will make error flows much more simpler.

@qiuming-best qiuming-best merged commit 224fc61 into vmware-tanzu:main Apr 17, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants