Add Restore err in Finalizing PV Patch phase if SC VolumeBindingMode is WaitForFirstConsumer #7869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is WaitForFirstConsumer Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog and fix CI error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
shubham-pampattiwar
force-pushed
the
add-restore-err-in-pv-patch
branch
from
d9c37c4
to
d38c953
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7869 +/- ##
==========================================
- Coverage 58.80% 58.78% -0.03%
==========================================
Files 345 345
Lines 28759 28769 +10
==========================================
Hits 16911 16911
- Misses 10420 10429 +9
- Partials 1428 1429 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks Shubham! |
sseago
approved these changes
Jun 12, 2024
aglitke
reviewed
Jun 13, 2024
| } | ||
| if *sc.VolumeBindingMode == storagev1api.VolumeBindingWaitForFirstConsumer { | ||
| ctx.logger.WithError(err).Errorf("StorageClass %s used by PV %s has VolumeBindingMode as WaitForFirstConsumer, you may need to be change it to Immediate if pods are excluded from backup", scName, pv.Name) | ||
| errs.Add(restoredNamespace, fmt.Errorf("StorageClass %s used by PV %s has VolumeBindingMode as WaitForFirstConsumer, you may need to be change it to Immediate if pods are excluded from backup", scName, pv.Name)) |
There was a problem hiding this comment.
It's not always possible or desirable to change the binding mode of a storage class. Consider local storage which really needs WFFC in order to function correctly. I think it's quite important to ensure that velero works with WaitForFirstConsumer storage.
|
Closing this PR in favor of #7953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7866
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.