Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip PV patch step in Restore workflow for WaitForFirstConsumer VolumeBindingMode Pending state PVCs (#7953) #8006

Conversation

shubham-pampattiwar
Copy link
Collaborator

Signed-off-by: Shubham Pampattiwar spampatt@redhat.com
(cherry picked from commit 3bd8a7d)

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7866

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (1c7412d) to head (7cb5b96).

Files Patch % Lines
pkg/controller/restore_finalizer_controller.go 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #8006      +/-   ##
================================================
- Coverage         58.79%   58.77%   -0.03%     
================================================
  Files               346      346              
  Lines             28823    28833      +10     
================================================
  Hits              16947    16947              
- Misses            10445    10454       +9     
- Partials           1431     1432       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…BindingMode Pending state PVCs (vmware-tanzu#7953)

add changelog file

change log level and add more detailed comments

make update

add return for sc get call if error

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
(cherry picked from commit 3bd8a7d)

update changelog

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
@shubham-pampattiwar shubham-pampattiwar changed the title Skip PV patch step in Restoe workflow for WaitForFirstConsumer VolumeBindingMode Pending state PVCs (#7953) Skip PV patch step in Restore workflow for WaitForFirstConsumer VolumeBindingMode Pending state PVCs (#7953) Jul 12, 2024
@Lyndon-Li Lyndon-Li merged commit 0c38aa2 into vmware-tanzu:release-1.14 Jul 15, 2024
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants