Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Reuse existing plugin manager for get/put volume info #8016

Merged

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jul 15, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Reuse existing plugin manager for get/put volume info.
Cherry-pick of #8012 and #8014

Does your change fix a particular issue?

Fixes #7925

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [x ] Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Scott Seago <sseago@redhat.com>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (0c38aa2) to head (89a5363).

Files Patch % Lines
pkg/backup/backup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #8016      +/-   ##
================================================
- Coverage         58.77%   58.77%   -0.01%     
================================================
  Files               346      346              
  Lines             28833    28818      -15     
================================================
- Hits              16947    16938       -9     
+ Misses            10454    10451       -3     
+ Partials           1432     1429       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Jul 16, 2024

@sseago DCO CI failed, so the PR cannot be merged. Looks like one commit was not signed off. Please help to fix it.

Lyndon-Li and others added 2 commits July 16, 2024 11:03
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Scott Seago <sseago@redhat.com>
Signed-off-by: Scott Seago <sseago@redhat.com>
@shubham-pampattiwar shubham-pampattiwar merged commit 6ae34a1 into vmware-tanzu:release-1.14 Jul 16, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants