Modifications to support VKS environment #8315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
the
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8315 +/- ##
==========================================
- Coverage 58.99% 58.97% -0.02%
==========================================
Files 367 367
Lines 38847 38876 +29
==========================================
+ Hits 22918 22928 +10
- Misses 14467 14486 +19
Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
blackpiglet
changed the title
blackpiglet
requested review from
reasonerjt
and removed request for
shubham-pampattiwar
blackpiglet
changed the title
reasonerjt
reviewed
Oct 18, 2024
| } | ||
|
|
||
| clusterFlavor := "VANILLA" |
There was a problem hiding this comment.
IMO instead of fallback based on error returned by "createxxxx" func, it's better to add another func to determine the flavor more explicitly.
There was a problem hiding this comment.
This can be improved in a subsequent PR.
reasonerjt
previously approved these changes
Oct 18, 2024
FYI, the TKGm envrionment support is deprecated. Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
Lyndon-Li
approved these changes
Oct 30, 2024
reasonerjt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.