Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change msg.autoanswer to msg.autoAnswer #420

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Feb 6, 2023

Signed-off-by: Yanan Shen yanans@vmware.com

Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm added this to the v2.3 milestone Feb 6, 2023
@keirazhang
Copy link
Contributor

Both "msg.autoanswer" and "msg.autoAnswer" should be fine. You can compare the lower case of extra config name in common/vm_set_extra_config.yml.

@123lzxm
Copy link
Collaborator Author

123lzxm commented Feb 7, 2023

Both "msg.autoanswer" and "msg.autoAnswer" should be fine. You can compare the lower case of extra config name in common/vm_set_extra_config.yml.

Thanks for your review. I thinks it's better to keep one format. Since "msg.autoanswer" does not work on main branch, so we prefer to use "msg.autoAnswer" .

Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@123lzxm 123lzxm merged commit 5f80f1f into vmware:main Feb 8, 2023
@123lzxm 123lzxm deleted the fix-typo branch March 15, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants