Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 12.2.0 vmtools_url_path and vmtools_iso_path for Windows #436

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Update 12.2.0 vmtools_url_path and vmtools_iso_path for Windows #436

merged 3 commits into from
Mar 17, 2023

Conversation

Winnie81
Copy link
Contributor

@Winnie81 Winnie81 commented Mar 16, 2023 •
edited
Loading

Fix 2466: Update 12.2.0 vmtools_url_path for Win

@Winnie81
Update 12.2.0 vmtools_url_path for Win
288c7d0 
Signed-off-by: Winnie81 <wyue@vmware.com>
@Winnie81 Winnie81 requested a review from keirazhang March 16, 2023 01:05
@vmwclabot
Copy link
Member

@Winnie81, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@Winnie81, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Winnie81 Winnie81 mentioned this pull request Mar 16, 2023
Closed
@Winnie81
modify a comment line
6a58b1c 
Signed-off-by: Winnie81 <wyue@vmware.com>
@Tomorrow9
Copy link
Member

We'd better exclude internal used ticket number in this external merge request in title Fix GOSV-2466: Update 12.2.0 vmtools_url_path for Win, thanks.

@Winnie81
Merge branch 'main' of github.com:Winnie81/ansible-vsphere-gos-valida…
01b7472 
…tion

Signed-off-by: Winnie81 <wyue@vmware.com>
@Winnie81 Winnie81 changed the title Fix GOSV-2466: Update 12.2.0 vmtools_url_path for Win Fix 2466: Update 12.2.0 vmtools_url_path for Win Mar 17, 2023
@keirazhang keirazhang changed the title Fix 2466: Update 12.2.0 vmtools_url_path for Win Update 12.2.0 vmtools_url_path and vmtools_iso_path for Windows Mar 17, 2023
keirazhang
keirazhang approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Winnie81 Winnie81 merged commit 8e13e97 into vmware:main Mar 17, 2023
@keirazhang keirazhang added this to the v2.3 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Winnie81 @vmwclabot @Tomorrow9 @keirazhang