Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 397: move check_vm_settings.yml to be executed after revert… #466

Merged
merged 6 commits into from
May 25, 2023

Conversation

ZouYuhua
Copy link
Collaborator

change code as #397 required.

… to base snasphot

Signed-off-by: ZouYuhua <zouy@vmware.com>
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Show resolved Hide resolved
ZouYuhua added 3 commits May 24, 2023 15:03
Signed-off-by: ZouYuhua <zouy@vmware.com>
Signed-off-by: ZouYuhua <zouy@vmware.com>
Signed-off-by: ZouYuhua <zouy@vmware.com>
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
env_setup/env_setup.yml Outdated Show resolved Hide resolved
ZouYuhua added 2 commits May 24, 2023 17:56
Signed-off-by: ZouYuhua <zouy@vmware.com>
… for when sentence

Signed-off-by: ZouYuhua <zouy@vmware.com>
@ZouYuhua
Copy link
Collaborator Author

ZouYuhua commented May 25, 2023

Pass for the testing after codereview with pardus 21.5 xfce:
image

Pass to run testcases after adding another nic to existing VM
image

Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@keirazhang keirazhang merged commit aa763a4 into vmware:main May 25, 2023
@keirazhang keirazhang added this to the v2.3 milestone May 25, 2023
@ZouYuhua ZouYuhua deleted the zouy_fix_issue_397 branch June 5, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants