Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature][openSUSE] Support openSUSE autoinstall #475

Merged
merged 4 commits into from
Jun 19, 2023
Merged

[New Feature][openSUSE] Support openSUSE autoinstall #475

merged 4 commits into from
Jun 19, 2023

Conversation

linhuali
Copy link
Collaborator

Description

  • openSUSE Leap is a classic stable distribution approach, 15.3 completely based on SLE's binary packages.
  • This change added an autoinst.xml file for openSUSE autoinstall and fixed the testcase failures.
  • Tested openSUSE 15.3/15.5 with lsilogic/lsilogicsas/sata/ide/pvscsi/nvme, vmxnet3/e1000e, efi/bios and passed.

Test Log

  • openSUSE 15.3:
VM information:
+---------------------------------------------------------------+
| Name                      | test_vm                           |
+---------------------------------------------------------------+
| Guest OS Distribution     | openSUSE Leap 15.3 x86_64         |
+---------------------------------------------------------------+
| GUI Installed             | True                              |
+---------------------------------------------------------------+
| CloudInit Version         |                                   |
+---------------------------------------------------------------+
| Hardware Version          | vmx-20                            |
+---------------------------------------------------------------+
| VMTools Version           | 11.2.5 (build-17337674)           |
+---------------------------------------------------------------+
| Config Guest Id           | opensuse64Guest                   |
+---------------------------------------------------------------+
| GuestInfo Guest Id        | opensuse64Guest                   |
+---------------------------------------------------------------+
| GuestInfo Guest Full Name | SUSE openSUSE (64-bit)            |
+---------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                        |
+---------------------------------------------------------------+
| GuestInfo Detailed Data   | bitness='64'                      |
|                           | distroName='openSUSE Leap'        |
|                           | distroVersion='15.3'              |
|                           | familyName='Linux'                |
|                           | kernelVersion='5.3.18-57-default' |
|                           | prettyName='openSUSE Leap 15.3'   |
+---------------------------------------------------------------+

Test Results (Total: 30, Passed: 24, Skipped: 6, Elapsed Time: 02:10:25)
+-------------------------------------------------------------------------+
| ID | Name                                 |   Status        | Exec Time |
+-------------------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3    |   Passed        | 00:38:26  |
| 02 | check_inbox_driver                   |   Passed        | 00:01:46  |
| 03 | ovt_verify_install                   |   Passed        | 00:10:37  |
| 04 | ovt_verify_status                    |   Passed        | 00:03:05  |
| 05 | vgauth_check_service                 |   Passed        | 00:01:09  |
| 06 | check_ip_address                     |   Passed        | 00:00:50  |
| 07 | check_os_fullname                    |   Passed        | 00:01:19  |
| 08 | stat_balloon                         |   Passed        | 00:00:58  |
| 09 | stat_hosttime                        |   Passed        | 00:00:52  |
| 10 | device_list                          |   Passed        | 00:02:54  |
| 11 | check_quiesce_snapshot_custom_script |   Passed        | 00:01:22  |
| 12 | memory_hot_add_basic                 |   Passed        | 00:06:31  |
| 13 | cpu_hot_add_basic                    |   Passed        | 00:05:46  |
| 14 | cpu_multicores_per_socket            |   Passed        | 00:08:20  |
| 15 | check_efi_firmware                   |   Passed        | 00:00:55  |
| 16 | secureboot_enable_disable            |   Passed        | 00:04:54  |
| 17 | e1000e_network_device_ops            |   Passed        | 00:04:34  |
| 18 | vmxnet3_network_device_ops           |   Passed        | 00:03:27  |
| 19 | pvrdma_network_device_ops            | * Not Supported | 00:01:21  |
| 20 | gosc_perl_dhcp                       | * Not Supported | 00:00:52  |
| 21 | gosc_perl_staticip                   | * Not Supported | 00:00:59  |
| 22 | gosc_cloudinit_dhcp                  | * Not Supported | 00:01:01  |
| 23 | gosc_cloudinit_staticip              | * Not Supported | 00:00:59  |
| 24 | paravirtual_vhba_device_ops          |   Passed        | 00:03:09  |
| 25 | lsilogic_vhba_device_ops             |   Passed        | 00:06:50  |
| 26 | lsilogicsas_vhba_device_ops          |   Passed        | 00:04:12  |
| 27 | sata_vhba_device_ops                 |   Passed        | 00:04:08  |
| 28 | nvme_vhba_device_ops                 |   Passed        | 00:03:53  |
| 29 | nvdimm_cold_add_remove               | * Not Supported | 00:01:30  |
| 30 | ovt_verify_uninstall                 |   Passed        | 00:02:17  |
+-------------------------------------------------------------------------+
  • openSUSE 15.5:
VM information:
+-----------------------------------------------------------------------+
| Name                      | test_vm                                   |
+-----------------------------------------------------------------------+
| Guest OS Distribution     | openSUSE Leap 15.5 x86_64                 |
+-----------------------------------------------------------------------+
| GUI Installed             | True                                      |
+-----------------------------------------------------------------------+
| CloudInit Version         |                                           |
+-----------------------------------------------------------------------+
| Hardware Version          | vmx-20                                    |
+-----------------------------------------------------------------------+
| VMTools Version           | 12.2.0 (build-21223074)                   |
+-----------------------------------------------------------------------+
| Config Guest Id           | opensuse64Guest                           |
+-----------------------------------------------------------------------+
| GuestInfo Guest Id        | opensuse64Guest                           |
+-----------------------------------------------------------------------+
| GuestInfo Guest Full Name | SUSE openSUSE (64-bit)                    |
+-----------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                |
+-----------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                        |
|                           | bitness='64'                              |
|                           | cpeString='cpe:/o:opensuse:leap:15.5'     |
|                           | distroAddlVersion='15.5'                  |
|                           | distroName='openSUSE Leap'                |
|                           | distroVersion='15.5'                      |
|                           | familyName='Linux'                        |
|                           | kernelVersion='5.14.21-150500.53-default' |
|                           | prettyName='openSUSE Leap 15.5'           |
+-----------------------------------------------------------------------+

Test Results (Total: 30, Passed: 24, Skipped: 6, Elapsed Time: 02:03:43)
+-------------------------------------------------------------------------+
| ID | Name                                 |   Status        | Exec Time |
+-------------------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3    |   Passed        | 00:27:23  |
| 02 | check_inbox_driver                   |   Passed        | 00:01:38  |
| 03 | ovt_verify_install                   |   Passed        | 00:10:56  |
| 04 | ovt_verify_status                    |   Passed        | 00:03:07  |
| 05 | vgauth_check_service                 |   Passed        | 00:01:16  |
| 06 | check_ip_address                     |   Passed        | 00:01:11  |
| 07 | check_os_fullname                    |   Passed        | 00:01:45  |
| 08 | stat_balloon                         |   Passed        | 00:00:59  |
| 09 | stat_hosttime                        |   Passed        | 00:01:04  |
| 10 | device_list                          |   Passed        | 00:03:12  |
| 11 | check_quiesce_snapshot_custom_script |   Passed        | 00:01:28  |
| 12 | memory_hot_add_basic                 |   Passed        | 00:06:29  |
| 13 | cpu_hot_add_basic                    |   Passed        | 00:06:01  |
| 14 | cpu_multicores_per_socket            |   Passed        | 00:08:54  |
| 15 | check_efi_firmware                   |   Passed        | 00:01:05  |
| 16 | secureboot_enable_disable            |   Passed        | 00:04:50  |
| 17 | e1000e_network_device_ops            |   Passed        | 00:04:13  |
| 18 | vmxnet3_network_device_ops           |   Passed        | 00:03:00  |
| 19 | pvrdma_network_device_ops            | * Not Supported | 00:01:25  |
| 20 | gosc_perl_dhcp                       | * Not Supported | 00:01:16  |
| 21 | gosc_perl_staticip                   | * Not Supported | 00:01:17  |
| 22 | gosc_cloudinit_dhcp                  | * Not Supported | 00:00:59  |
| 23 | gosc_cloudinit_staticip              | * Not Supported | 00:00:59  |
| 24 | paravirtual_vhba_device_ops          |   Passed        | 00:02:54  |
| 25 | lsilogic_vhba_device_ops             |   Passed        | 00:08:56  |
| 26 | lsilogicsas_vhba_device_ops          |   Passed        | 00:03:57  |
| 27 | sata_vhba_device_ops                 |   Passed        | 00:04:00  |
| 28 | nvme_vhba_device_ops                 |   Passed        | 00:03:46  |
| 29 | nvdimm_cold_add_remove               | * Not Supported | 00:01:30  |
| 30 | ovt_verify_uninstall                 |   Passed        | 00:02:47  |
+-------------------------------------------------------------------------+

@vmwclabot
Copy link
Member

@linhuali, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

keirazhang
keirazhang reviewed Jun 19, 2023
View reviewed changes
linux/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
autoinstall/README.md Show resolved Hide resolved
@keirazhang
Copy link
Contributor

Please sign off all of your commits (git commit -s --amend) to remove dco-required label.

@linhuali linhuali force-pushed the fix_opensuse_autoinstall branch from fd88cf4 to 0f4a8a9 Compare June 19, 2023 02:07
@vmwclabot
Copy link
Member

@linhuali, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

linhuali added 4 commits June 19, 2023 06:29
@linhuali
add autoinstall support for openSUSE
4ef064c 
Signed-off-by: linhuali <lli@vmware.com>
@linhuali
fix the testcase failures for openSUSE
97a99e4 
Signed-off-by: linhuali <lli@vmware.com>
@linhuali
fix the BIOS failure of openSUSE autoinstall
5f7b7e9 
Signed-off-by: linhuali <lli@vmware.com>
@linhuali
fix deploy_vm_from_iso and README.md for openSUSE
fca76cc 
Signed-off-by: linhuali <lli@vmware.com>
@linhuali linhuali force-pushed the fix_opensuse_autoinstall branch from 0f4a8a9 to fca76cc Compare June 19, 2023 06:30
keirazhang
keirazhang approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@linhuali linhuali merged commit 086ba9b into vmware:main Jun 19, 2023
@keirazhang keirazhang added this to the v3.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@linhuali @vmwclabot @keirazhang