-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Shutdown guest OS after auto install completes instead of rebooting #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Zhang <qiz@vmware.com>
Signed-off-by: Qi Zhang <qiz@vmware.com>
Signed-off-by: Qi Zhang <qiz@vmware.com>
Signed-off-by: Qi Zhang <qiz@vmware.com>
Signed-off-by: Qi Zhang <qiz@vmware.com>
Signed-off-by: Qi Zhang <qiz@vmware.com>
123lzxm
reviewed
Aug 14, 2023
linhuali
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
123lzxm
reviewed
Aug 14, 2023
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 15, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 16, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 17, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 22, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 22, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 25, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Aug 25, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 1, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 1, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 11, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 11, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 18, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 18, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 25, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 25, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 27, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 27, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 12, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 12, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 30, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 30, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Nov 17, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Nov 17, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Nov 24, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 4, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 12, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 19, 2023
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 11, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 15, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 30, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 2, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 2, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 21, 2024
…mware#489 Signed-off-by: linhuali <lli@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though guest OS sends autoinstall complete message to serial port, it might still be running some post tasks and it won't be rebooted immediately. Sometimes the post tasks take some time, which led to ansible tasks thought starting to wait for guest full name but it failed due to guest OS hasn't reboot at all.
It is difficult to find the best timing when to wait for guest full name, so in this change I replaced 'reboot' with 'shutdown' as the following action after autoinstall is compeleted. Therefore, we only needs to wait for VM's power states becoming poweredOff after autoinstall complete message received. Then we can consider the complete autoinstall process is finished, and then power on VM to wait for its guest full name.
In this change, I also added boot options for redirecting console output to serial port, so we can have more information when debugging deploy_vm failures.