Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty hardware version in collected OVF config info and guest_info.json #497

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

keirazhang
Copy link
Contributor

@keirazhang keirazhang commented Sep 1, 2023

The hardware version in collected OVF config info is empty without this fix, as below:

"ovf_vm_hardware_config": {
            "CPU Cores per Socket": 1,
            "CPU Hot Add Enabled": false,
            "CPU I/O MMU": false,
            "CPU Nested HV Enabled": false,
            "CPU Number": 2,
            "Firmware": "efi",
            "Guest OS ID": "rhel8_64Guest",
            "Guest OS Version": "Red Hat Enterprise Linux 8 (64-bit)",
            "Hardware Version": "",
            "Memory Hot Add Enabled": false,
            "Memory Size in MB": 4096,
            "Secure Boot": false,
            "VBS Enabled": false,
            "Virtual TPM": false
        }

With this fix:

"ovf_vm_hardware_config": {
            "CPU Cores per Socket": 1,
            "CPU Hot Add Enabled": false,
            "CPU I/O MMU": false,
            "CPU Nested HV Enabled": false,
            "CPU Number": 2,
            "Firmware": "efi",
            "Guest OS ID": "rhel8_64Guest",
            "Guest OS Version": "Red Hat Enterprise Linux 8 (64-bit)",
            "Hardware Version": "vmx-15",
            "Memory Hot Add Enabled": false,
            "Memory Size in MB": 4096,
            "Secure Boot": false,
            "VBS Enabled": false,
            "Virtual TPM": false

guest_info.json

[
    {
        "Guest_OS_Distribution": "",
        "ESXi_Version": "8.0.3",
        "ESXi_Build": "22375478",
        "Hardware_Version": "vmx-15",
        "VMTools_Version": "12.1.5 (build-20735119)",
        "Config_Guest_Id": "rhel8_64Guest",
        "GuestInfo_Guest_Id": "rhel8_64Guest",
        "GuestInfo_Guest_Full_Name": "Red Hat Enterprise Linux 8 (64-bit)",
        "GuestInfo_Guest_Family": "linuxGuest",
        "GuestInfo_Detailed_Data": ""
    }
]

Signed-off-by: Qi Zhang <qiz@vmware.com>
@keirazhang keirazhang added this to the v3.0 milestone Sep 1, 2023
@keirazhang keirazhang changed the title Fix empty hardware version in collected OVF config info Fix empty hardware version in collected OVF config info and guest_info.json Sep 1, 2023
@keirazhang keirazhang force-pushed the fix_ovf_hardware_version branch from df3c935 to 798a6b9 Compare September 4, 2023 04:35
Signed-off-by: Qi Zhang <qiz@vmware.com>
@keirazhang keirazhang force-pushed the fix_ovf_hardware_version branch from 798a6b9 to 756c0dd Compare September 4, 2023 11:20
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@keirazhang keirazhang merged commit 19ba91d into vmware:main Sep 6, 2023
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Sep 11, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Sep 18, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Sep 25, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Sep 27, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Oct 12, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Oct 30, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Nov 17, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Nov 24, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Dec 4, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Dec 12, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Dec 19, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 11, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 15, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 30, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Feb 2, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Feb 2, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali added a commit to linhuali/ansible-vsphere-gos-validation that referenced this pull request Feb 21, 2024
Signed-off-by: linhuali <lli@vmware.com>
@keirazhang keirazhang deleted the fix_ovf_hardware_version branch March 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants