-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty hardware version in collected OVF config info and guest_info.json #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Zhang <qiz@vmware.com>
keirazhang
changed the title
Fix empty hardware version in collected OVF config info
Fix empty hardware version in collected OVF config info and guest_info.json
Sep 1, 2023
keirazhang
force-pushed
the
fix_ovf_hardware_version
branch
from
September 4, 2023 04:35
df3c935
to
798a6b9
Compare
Signed-off-by: Qi Zhang <qiz@vmware.com>
keirazhang
force-pushed
the
fix_ovf_hardware_version
branch
from
September 4, 2023 11:20
798a6b9
to
756c0dd
Compare
123lzxm
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 11, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 18, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 25, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Sep 27, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 12, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Oct 30, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Nov 17, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Nov 24, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 4, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 12, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Dec 19, 2023
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 11, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 15, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 30, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Jan 31, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 2, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 2, 2024
Signed-off-by: linhuali <lli@vmware.com>
linhuali
added a commit
to linhuali/ansible-vsphere-gos-validation
that referenced
this pull request
Feb 21, 2024
Signed-off-by: linhuali <lli@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware version in collected OVF config info is empty without this fix, as below:
With this fix:
guest_info.json