Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Fix undefined variables at rescue or always block when test_setup failed #504

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

keirazhang
Copy link
Contributor

If test case fails at test_setup, some variables used in rescue or always block may be not defined but used, which would lead to variable undefined error. This fix is to add conditions to use those variables.

Signed-off-by: Qi Zhang <qiz@vmware.com>
@keirazhang keirazhang added this to the v3.0 milestone Sep 25, 2023
linhuali
linhuali previously approved these changes Sep 25, 2023
Copy link
Collaborator

@linhuali linhuali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: Qi (Keira) Zhang <qiz@vmware.com>
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@keirazhang keirazhang merged commit 2887517 into vmware:main Sep 26, 2023
@keirazhang keirazhang deleted the fix_undefined_vars branch March 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants