Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MiracleLinux] check_os_fullname failed for MiracleLinux-8.x with latest VMware Tools #513

Merged
merged 8 commits into from
Nov 17, 2023
Merged

[MiracleLinux] check_os_fullname failed for MiracleLinux-8.x with latest VMware Tools #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed6378b
fix issue: VM's guest id in guest info is 'asianux8_64Guest', not exp…
Nov 10, 2023
807344d
change code as codereview
Nov 14, 2023
bf243d9
change code as codereview
Nov 14, 2023
5ef2ff8
modify readme to declare supporting miracle linux 8.x with ansible
Nov 15, 2023
4d0b857
change code as codereview
Nov 15, 2023
83d8aef
change code as codereview
Nov 15, 2023
52b2098
change task name
Nov 15, 2023
f32e171
modify readme to support miracle linux 9.x
Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ This project supports below scenarios for end-to-end guest operating system vali
| BCLinux-for-Euler 21.10 | :heavy_check_mark: | | :heavy_check_mark: |
| Red Hat Enterprise Linux CoreOS (RHCOS) 4.13 and later | | :heavy_check_mark: | :heavy_check_mark: |
| FusionOS 22 and 23 | :heavy_check_mark: | | :heavy_check_mark: |
| Miracle Linux 8.x, 9.x | :heavy_check_mark: | | :heavy_check_mark: |

**Notes**
This compatible guest operating systems list is used for this project only. For guest operating system support status on ESXi, please refer to [VMware Compatibility Guide](https://www.vmware.com/resources/compatibility/search.php?deviceCategory=software&testConfig=16).
Expand Down
24 changes: 24 additions & 0 deletions linux/check_os_fullname/miracle_fullname_map.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Copyright 2023 VMware, Inc.
# SPDX-License-Identifier: BSD-2-Clause
---
# Guest id "asianux8_64Guest" and full name "MIRACLE LINUX 8 (64-bit)" is available on ESXi 6.7P06 or later

- name: "Set facts when vmtools_version is larger than 12.3.5"
when:
- vmtools_version is defined
- vmtools_version is version('12.3.5', '>')
block:
- name: "Set fact of expected guest OS major version on ESXi {{ esxi_version }}"
ansible.builtin.set_fact:
expected_guest_major_ver: "{{ [guest_os_ansible_distribution_major_ver | int, 8 ] | min }}"

- name: "Set fact of expected guest id suffix"
ansible.builtin.set_fact:
guest_is_otherlinux: false
expected_guest_id_suffix: "{{ expected_guest_id_suffix | replace('64', '_64') }}"
ZouYuhua marked this conversation as resolved.
Show resolved Hide resolved

- name: "Set expected guest id and full name for {{ vm_guest_os_distribution }}"
ansible.builtin.set_fact:
expected_guest_id: "asianux{{ expected_guest_major_ver }}{{ expected_guest_id_suffix }}"
expected_guest_fullname: "MIRACLE LINUX {{ expected_guest_major_ver }} ({{ guest_os_bit }})"

2 changes: 1 addition & 1 deletion linux/check_os_fullname/set_guestinfo_without_shortname.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

- name: "Set expected guest id and full name for {{ vm_guest_os_distribution }}"
include_tasks: "{{ guest_os_ansible_distribution | lower }}_fullname_map.yml"
when: guest_os_ansible_distribution in ["Amazon", "CentOS", "OracleLinux", "AlmaLinux", "Rocky", "Debian", "FreeBSD"]
when: guest_os_ansible_distribution in ["Amazon", "CentOS", "OracleLinux", "AlmaLinux", "Rocky", "Debian", "FreeBSD", "MIRACLE"]

- name: "Set expected guest id and full name for {{ vm_guest_os_distribution }}"
ansible.builtin.set_fact:
Expand Down