Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Disable BitLocker before GOSC #515

Merged
merged 11 commits into from
Nov 17, 2023
Merged

[Windows] Disable BitLocker before GOSC #515

merged 11 commits into from
Nov 17, 2023

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Nov 15, 2023

sysprep which is used by GOSC in Window OS will fail if the OS volumes are encrypted by BitLocker Device Encryption.

So will disable it before running GOSC.

@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from 9d56b91 to 30407a3 Compare November 15, 2023 03:04
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm
disable BitLocker before GOSC
8d9506b 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from 30407a3 to 3eec4ff Compare November 15, 2023 03:07
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm 123lzxm added this to the 3.1 milestone Nov 15, 2023
Tomorrow9
Tomorrow9 requested changes Nov 15, 2023
View reviewed changes
windows/guest_customization/win_gosc_prepare.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/utils/win_get_bitlocker_volume.yml Outdated Show resolved Hide resolved
windows/utils/win_get_bitlocker_volume.yml Outdated Show resolved Hide resolved
windows/utils/win_get_bitlocker_volume.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/guest_customization/win_gosc_prepare.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from 4f36ca9 to c1777dc Compare November 15, 2023 05:46
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from c1777dc to 84428c5 Compare November 15, 2023 05:57
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from 84428c5 to b620277 Compare November 15, 2023 06:24
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm
address comments
b7067c1 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
add task to check decryption failure
f433c92 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from b620277 to f433c92 Compare November 15, 2023 06:27
@123lzxm
save the check result to a variable
25a1c04 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Address new comments
e318e88 
Signed-off-by: Yanan Shen <yanans@vmware.com>
keirazhang
keirazhang reviewed Nov 16, 2023
View reviewed changes
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
windows/utils/win_disable_bitlocker.yml Outdated Show resolved Hide resolved
@123lzxm
split the function of disable BitLocerk service and decrypt volume
ca14041 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm force-pushed the gosc-disable-bitlocker branch from dbb053b to ca14041 Compare November 16, 2023 06:55
@123lzxm
change fail condition
d280376 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
change fail conditions
b33ec32 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
add utils path
3319d28 
Signed-off-by: Yanan Shen <yanans@vmware.com>
keirazhang
keirazhang previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@123lzxm
BitLocker is not available on windows server
9ad00b9 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Simplify the when condition
1a2d6de 
Signed-off-by: Yanan Shen <yanans@vmware.com>
Tomorrow9
Tomorrow9 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@123lzxm 123lzxm merged commit b1e1781 into vmware:main Nov 17, 2023
@123lzxm 123lzxm deleted the gosc-disable-bitlocker branch January 10, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang left review comments

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@123lzxm @vmwclabot @keirazhang @Tomorrow9