Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add new test case vtpm_cold_add_remove #516

Merged
merged 9 commits into from
Nov 23, 2023
Merged

[Windows] Add new test case vtpm_cold_add_remove #516

merged 9 commits into from
Nov 23, 2023

Conversation

Tomorrow9
Copy link
Member

Add a new Windows test case vtpm_cold_add_remove.

  1. If current VM has vTPM device already, clone a new VM for vTPM testing.
  2. If current VM without vTPM device, instant clone a new VM for vTPM testing.

@Tomorrow9 Tomorrow9 added this to the 3.1 milestone Nov 15, 2023
keirazhang
keirazhang reviewed Nov 15, 2023
View reviewed changes
linux/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
vars/test.yml Outdated Show resolved Hide resolved
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/utils/win_get_tpm_status.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/cold_add_vtpm.yml Outdated Show resolved Hide resolved
common/vm_get_cryptokey_id.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Show resolved Hide resolved
common/vm_get_cryptokey_id.yml Outdated Show resolved Hide resolved
123lzxm
123lzxm reviewed Nov 16, 2023
View reviewed changes
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_test.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/cold_add_vtpm.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_test.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_test.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_test.yml Outdated Show resolved Hide resolved
@Tomorrow9
Copy link
Member Author

Hi, @keirazhang @123lzxm do you have any other comments? Thanks.

keirazhang
keirazhang reviewed Nov 20, 2023
View reviewed changes
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/deploy_vm/deploy_vm_from_iso.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/vtpm_add_remove_check.yml Outdated Show resolved Hide resolved
windows/utils/win_get_tpm_status.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/cold_add_vtpm.yml Outdated Show resolved Hide resolved
windows/vtpm_cold_add_remove/cold_add_vtpm.yml Show resolved Hide resolved
windows/vtpm_cold_add_remove/cold_add_vtpm.yml Outdated Show resolved Hide resolved
@Tomorrow9
add vTPM test case
f937063 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add vtpm test case
f3c6e34 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add vtpm test case
cc44884 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add tpm test case
b595b4d 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address review comments
ae45d18 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address review comments
cdeed42 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
cdc6cc4 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address review comments
0d59a5a 
Signed-off-by: Diane Wang <dianew@vmware.com>
keirazhang
keirazhang previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9
address review comments
7c92124 
Signed-off-by: Diane Wang <dianew@vmware.com>
123lzxm
123lzxm approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Tomorrow9 Tomorrow9 merged commit 39cddcc into vmware:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm approved these changes

@keirazhang keirazhang keirazhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomorrow9 @keirazhang @123lzxm