Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Install windows update patch by msu file #525

Merged
merged 21 commits into from
Jan 10, 2024
Merged

[Windows] Install windows update patch by msu file #525

merged 21 commits into from
Jan 10, 2024

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Dec 19, 2023

Install the specific windows update patch which is *.msu file.

@123lzxm 123lzxm added this to the 3.1 milestone Dec 19, 2023
Tomorrow9
Tomorrow9 reviewed Dec 20, 2023
View reviewed changes
vars/test.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
Tomorrow9
Tomorrow9 reviewed Dec 21, 2023
View reviewed changes
windows/windows_update/win_update_restore_snapshot.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
keirazhang
keirazhang reviewed Dec 21, 2023
View reviewed changes
windows/windows_update/win_update_restore_snapshot.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
windows/windows_update/windows_update.yml Outdated Show resolved Hide resolved
windows/windows_update/win_update_restore_snapshot.yml Outdated Show resolved Hide resolved
@keirazhang
Copy link
Contributor

You may refer to below docs about Ansible Vault for password encryption and decryption.
https://docs.ansible.com/ansible/latest/vault_guide/index.html
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/vault_filter.html
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/unvault_filter.html

which should be a more proper and safer solution for this case.

@123lzxm 123lzxm force-pushed the add-suvp branch 2 times, most recently from 1f814f1 to 1eea975 Compare December 26, 2023 08:26
keirazhang
keirazhang reviewed Jan 3, 2024
View reviewed changes
common/add_host_in_memory_inventory.yml Outdated Show resolved Hide resolved
main.yml Outdated Show resolved Hide resolved
@123lzxm 123lzxm force-pushed the add-suvp branch 3 times, most recently from ebeae2a to d6924c5 Compare January 3, 2024 09:23
@123lzxm 123lzxm force-pushed the add-suvp branch 3 times, most recently from b97d7d0 to b6169b5 Compare January 9, 2024 07:07
Tomorrow9
Tomorrow9 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

keirazhang
keirazhang reviewed Jan 9, 2024
View reviewed changes
vars/test.yml Outdated Show resolved Hide resolved
windows/utils/win_execute_cmd.yml Outdated Show resolved Hide resolved
keirazhang
keirazhang previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

123lzxm added 3 commits January 9, 2024 16:37
@123lzxm
windows update test
d490385 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
use tempalte to generate the ps1 script
53a17af 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
try parameter forcerestart
0f3aea1 
Signed-off-by: Yanan Shen <yanans@vmware.com>
123lzxm added 17 commits January 9, 2024 16:37
@123lzxm
install msu file
1b2cfe1 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Add case to restore the original base snapshot
55a8664 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
remove tempalte
6840641 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
get msu file from folder
80cd85d 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
exit testing when msu installation failed
8d0fa81 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
add windows_msu_share_point to vars file
2b4d01e 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
do not display server password in log
f8008a1 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
address comments
0e31880 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
fix some logic
aa08bc3 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
restore the basesnpashot in env_cleanup
37311dd 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
fix review comments
4b08e7d 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
split file windows_update_install.yml
4f2ce98 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
address new comments
f784f3e 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
fix review comments
cf5c246 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
address comments
b699d52 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
modify the task name
eed248c 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
change var name
9ddc7d7 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm force-pushed the add-suvp branch 2 times, most recently from 53a2da8 to dec67c4 Compare January 9, 2024 09:05
@123lzxm
add one parameter to utility win_execute_cmd.yml
1afa4fc 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Copy link
Collaborator Author

123lzxm commented Jan 9, 2024 •
edited
Loading 

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:16:55)
+--------------------------------------------------+
| ID | Name                   | Status | Exec Time |
+--------------------------------------------------+
|  1 | windows_update_install | Passed | 00:16:33  |
+--------------------------------------------------+

Tomorrow9
Tomorrow9 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@123lzxm 123lzxm merged commit 3e2708d into vmware:main Jan 10, 2024
ZouYuhua pushed a commit to ZouYuhua/ansible-vsphere-gos-validation that referenced this pull request Jan 18, 2024
@123lzxm @ZouYuhua
[Windows] Install windows update patch by msu file (vmware#525)
acb350d 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm 123lzxm deleted the add-suvp branch April 24, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

@keirazhang keirazhang keirazhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@123lzxm @keirazhang @Tomorrow9