Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get VM primary mac address after VM power on #529

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Get VM primary mac address after VM power on #529

merged 3 commits into from
Jan 9, 2024

Conversation

keirazhang
Copy link
Contributor

@keirazhang keirazhang commented Jan 6, 2024 •
edited
Loading

The VM might not have MAC address after vm_create.yml, which led to vm_primary_nic_mac not set and failing to get VM IP. Changes in this PR fixes this issue.

@keirazhang
Retry to get VM primary mac address after autoinstall completes
18accbb 
Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
@keirazhang keirazhang added this to the 3.1 milestone Jan 6, 2024
@keirazhang keirazhang requested a review from linhuali January 6, 2024 08:01
@keirazhang
Move out vm_wait_primary_nic_mac.yml from vm_get_vm_info.yml
7d2ef02 
Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
Tomorrow9
Tomorrow9 reviewed Jan 8, 2024
View reviewed changes
env_setup/env_setup.yml Outdated Show resolved Hide resolved
common/vm_wait_primary_nic_mac.yml Show resolved Hide resolved
@keirazhang
Update task file path and assertion for vm_primary_nic_mac
afd66da 
Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
@keirazhang keirazhang changed the title Retry to get VM primary mac address after autoinstall completes Get VM primary mac address after VM power on Jan 9, 2024
@keirazhang
Copy link
Contributor Author

new_vm=true

Testbed information:
+-------------------------------------------------------------------------------------------+
| Product | Version | Build    | Hostname or IP | Server Model                              |
+-------------------------------------------------------------------------------------------+
| ESXi    | 8.0.2   | 22380479 | x.x.x.x | VMware, Inc. VMware20,1                   |
|         |         |          |                | Intel(R) Xeon(R) Gold 6230R CPU @ 2.10GHz |
+-------------------------------------------------------------------------------------------+


VM information:
+----------------------------------------------------+
| Name                      | test_vm-3              |
+----------------------------------------------------+
| Guest OS Distribution     | FusionOS 22.0.4 x86_64 |
+----------------------------------------------------+
| IP                        |  x.x.x.x          |
+----------------------------------------------------+
| GUI Installed             | True                   |
+----------------------------------------------------+
| CloudInit Version         |                        |
+----------------------------------------------------+
| Hardware Version          | vmx-21                 |
+----------------------------------------------------+
| VMTools Version           |                        |
+----------------------------------------------------+
| Config Guest Id           | other4xLinux64Guest    |
+----------------------------------------------------+
| GuestInfo Guest Id        |                        |
+----------------------------------------------------+
| GuestInfo Guest Full Name |                        |
+----------------------------------------------------+
| GuestInfo Guest Family    |                        |
+----------------------------------------------------+
| GuestInfo Detailed Data   |                        |
+----------------------------------------------------+


Test Results (Total: 1, Passed: 1, Elapsed Time: 00:26:56)
+------------------------------------------------------+
| ID | Name                       | Status | Exec Time |
+------------------------------------------------------+
|  1 | deploy_vm_efi_sata_vmxnet3 | Passed | 00:26:41  |
+------------------------------------------------------+

new_vm=false

Testbed information:
+-------------------------------------------------------------------------------------------+
| Product | Version | Build    | Hostname or IP | Server Model                              |
+-------------------------------------------------------------------------------------------+
| ESXi    | 8.0.2   | 22380479 | x.x.x.x | VMware, Inc. VMware20,1                   |
|         |         |          |                | Intel(R) Xeon(R) Gold 6230R CPU @ 2.10GHz |
+-------------------------------------------------------------------------------------------+


VM information:
+----------------------------------------------------+
| Name                      | test_vm-2              |
+----------------------------------------------------+
| Guest OS Distribution     | FusionOS 22.0.4 x86_64 |
+----------------------------------------------------+
| IP                        | x.x.x.x          |
+----------------------------------------------------+
| GUI Installed             | True                   |
+----------------------------------------------------+
| CloudInit Version         | 19.4                   |
+----------------------------------------------------+
| Hardware Version          | vmx-21                 |
+----------------------------------------------------+
| VMTools Version           |                        |
+----------------------------------------------------+
| Config Guest Id           | other4xLinux64Guest    |
+----------------------------------------------------+
| GuestInfo Guest Id        |                        |
+----------------------------------------------------+
| GuestInfo Guest Full Name |                        |
+----------------------------------------------------+
| GuestInfo Guest Family    |                        |
+----------------------------------------------------+
| GuestInfo Detailed Data   |                        |
+----------------------------------------------------+


Test Results (Total: 1, Passed: 1, Elapsed Time: 00:01:27)
+----------------------------------------------+
| ID | Name               | Status | Exec Time |
+----------------------------------------------+
|  1 | check_inbox_driver | Passed | 00:01:10  |
+----------------------------------------------+

Tomorrow9
Tomorrow9 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit 5d57aab into vmware:main Jan 9, 2024
ZouYuhua pushed a commit to ZouYuhua/ansible-vsphere-gos-validation that referenced this pull request Jan 18, 2024
@keirazhang @ZouYuhua
Get VM primary mac address after VM power on (vmware#529)
a977f3b 
Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
@keirazhang keirazhang deleted the wait_primary_nic branch March 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm left review comments

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

@linhuali linhuali Awaiting requested review from linhuali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@keirazhang @Tomorrow9 @123lzxm