Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Install online Windows Updates #552

Merged
merged 23 commits into from
Feb 27, 2024
Merged

[Windows] Install online Windows Updates #552

merged 23 commits into from
Feb 27, 2024

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Feb 23, 2024

Before installing the .msu file in case windows_update_install, install the online Windows Updates firstly.

123lzxm added 21 commits February 23, 2024 14:48
@123lzxm
run windows updates
e21ee43 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
for test
8f7a766 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
add input parameter for utility win_install_updates.yml
4993e0f 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
sanpshot description
3e48bfa 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
add rejest_list for win_update
3701798 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
handle konwn issue for windows server 2022
55cd96b 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
seprate run_windows_updates as a new case
6febfe8 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
rebase main
ad53f39 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
increase the timeout for win_updates to 45 minutes
190d09e 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Fetch Windows Updates log file
f291c38 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
for test, add reject list for windows 10 v22h2
b3bb898 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
ignore error for deleting file
8cc25cb 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
change some description message
46f79c3 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
merge the seperate case run_windows_updates to windows_updates_install
a807a4e 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
revert to base snapshot if online update failed
82b1ad8 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
remove block resuce and modify windows updates utility
d4f246f 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
revert to basesnapshot if online windows updates failed
742fc44 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
remove test case run_windows_updates
0f4d23f 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
take snapshot for online updates failure
c2ff755 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
remove logic of taking sanpshot for online update failure
6a414f2 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
remove the commented lines
cb20871 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@123lzxm
address comments and rename utility job win_install_updates
5a49dc7 
Signed-off-by: Yanan Shen <yanans@vmware.com>
Tomorrow9
Tomorrow9 reviewed Feb 26, 2024
View reviewed changes
common/reset_base_snapshot.yml Outdated Show resolved Hide resolved
vars/test.yml Outdated Show resolved Hide resolved
windows/utils/win_install_online_updates.yml Outdated Show resolved Hide resolved
windows/windows_update_install/install_online_updates.yml Show resolved Hide resolved
@123lzxm
address new comments
1e2a636 
Signed-off-by: Yanan Shen <yanans@vmware.com>
Tomorrow9
Tomorrow9 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， thanks

@123lzxm 123lzxm merged commit 17cda80 into vmware:main Feb 27, 2024
@keirazhang keirazhang added this to the 3.2 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang left review comments

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@123lzxm @vmwclabot @keirazhang @Tomorrow9