Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix OS in-place upgrade issues from Windows Server 2012 R2 and Windows Server 2016 #578

Merged
merged 14 commits into from
May 17, 2024
Merged

[Windows] Fix OS in-place upgrade issues from Windows Server 2012 R2 and Windows Server 2016 #578

merged 14 commits into from
May 17, 2024

Conversation

Tomorrow9
Copy link
Member

@Tomorrow9 Tomorrow9 commented May 11, 2024 •
edited
Loading

In Windows Server 2012 R2 or 2016 guest OS, get Windows Server 2025 image info as below:

TASK [Execute PowerShell command] **********************************************
task path: /home/worker/workspace/Ansible_Windows_Server_LTSC_Upgrade2016_MAIN_NVME_E1000E_EFI/ansible-vsphere-gos-validation/windows/utils/win_execute_cmd.yml:23
changed: [localhost -> test_vm] => {
    "changed": true,
    "cmd": "Get-WindowsImage -ImagePath D:\\sources\\install.wim",
    "delta": "0:00:21.125000",
    "end": "2024-05-10 09:50:20.468477",
    "rc": 0,
    "start": "2024-05-10 09:49:59.343477",
    "stderr": "",
    "stderr_lines": [],
....
    "stdout_lines": [
        "",
        "",
        "ImageIndex       : 1",
        "ImageName        : Windows Server 2025 SERVERSTANDARDCORE",
        "ImageDescription : Windows Server 2025 SERVERSTANDARDCORE",
        "ImageSize        : 8,953,831,686 bytes",
        "",
        "ImageIndex       : 2",
        "ImageName        : Windows Server 2025 SERVERSTANDARD",
        "ImageDescription : Windows Server 2025 SERVERSTANDARD",
        "ImageSize        : 18,945,747,354 bytes",
        "",
        "ImageIndex       : 3",
        "ImageName        : Windows Server 2025 SERVERDATACENTERCORE",
        "ImageDescription : Windows Server 2025 SERVERDATACENTERCORE",
        "ImageSize        : 8,949,864,520 bytes",
        "",
        "ImageIndex       : 4",
        "ImageName        : Windows Server 2025 SERVERDATACENTER",
        "ImageDescription : Windows Server 2025 SERVERDATACENTER",
        "ImageSize        : 18,946,223,263 bytes",
        "",
        "",
        ""
    ]

Tomorrow9 added 4 commits May 9, 2024 03:18
@Tomorrow9
add get Windows image info
727b793 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
update get image index
a9d68f8 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix syntax issue
5d25925 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix syntax error
a7fcaf8 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9 Tomorrow9 added this to the 3.2 milestone May 11, 2024
@Tomorrow9
fix guest fullname compare issue
a7800d1 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
44e7686 
Signed-off-by: Diane Wang <dianew@vmware.com>
@123lzxm
Copy link
Collaborator

123lzxm commented May 13, 2024

How about Windows Server 2012 R2? What's the image info got from it?

@Tomorrow9
fix no cmdlets issue
10fa9c3 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9 Tomorrow9 marked this pull request as draft May 14, 2024 06:35
@Tomorrow9 Tomorrow9 changed the title [Windows] Change keyword for getting OS image index [Windows] Fix OS in-place upgrade issues from Windows Server 2012 R2 May 14, 2024
@Tomorrow9 Tomorrow9 changed the title [Windows] Fix OS in-place upgrade issues from Windows Server 2012 R2 [Windows] Fix OS in-place upgrade issues from Windows Server 2012 R2 and Windows Server 2016 May 14, 2024
Tomorrow9 added 5 commits May 14, 2024 07:19
@Tomorrow9
change to CDROM size
2f46c02 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix edition issue
ac59bc8 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix get edition issue
175448f 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add debug for become
1526907 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
set become for Windows Server 2012 R2
aa88857 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
Copy link
Member Author

How about Windows Server 2012 R2? What's the image info got from it?

It's the same as Windows Server 2016.

@Tomorrow9 Tomorrow9 marked this pull request as ready for review May 17, 2024 03:25
Tomorrow9 added 2 commits May 17, 2024 06:24
@Tomorrow9
address comments
a62c8b3 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
update become condition
939f455 
Signed-off-by: Diane Wang <dianew@vmware.com>
keirazhang
keirazhang approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9 Tomorrow9 merged commit 2e891d0 into vmware:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomorrow9 @123lzxm @keirazhang