Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FreeBSD]fix: install open-vm-tools-nox11 by mistake for freebsd 64bit #580

Merged
merged 5 commits into from
May 23, 2024

Conversation

ZouYuhua
Copy link
Collaborator

Issue:
install open-vm-tools-nox11 by mistake for freebsd 64bit

Test result:

  1. Test result for FreeBSD 14 & 13 32bit:
    -----------------------------------------------------------------+
    | 1 | deploy_vm_bios_nvme_vmxnet3 | Passed | 00:38:36 |
    | 2 | ovt_verify_status | * Not Applicable | 00:00:45 |
    +-----------------------------------------------------------------+

  2. Test result for FreeBSD 14 & 13 64bit:
    Test Results (Total: 2, Passed: 2, Elapsed Time: 00:38:27)
    +------------------------------------------------------+
    | ID | Name | Status | Exec Time |
    +------------------------------------------------------+
    | 1 | deploy_vm_efi_nvme_vmxnet3 | Passed | 00:37:14 |
    | 2 | ovt_verify_status | Passed | 00:00:59 |
    +------------------------------------------------------+

Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@keirazhang
Copy link
Contributor

Test result for FreeBSD 14 & 13 32bit:
-----------------------------------------------------------------+
| 1 | deploy_vm_bios_nvme_vmxnet3 | Passed | 00:38:36 |
| 2 | ovt_verify_status | * Not Applicable | 00:00:45 | ---------------> This result is incorrect
+-----------------------------------------------------------------+

@ZouYuhua
Copy link
Collaborator Author

Test result for FreeBSD 14 & 13 32bit: -----------------------------------------------------------------+ | 1 | deploy_vm_bios_nvme_vmxnet3 | Passed | 00:38:36 | | 2 | ovt_verify_status | * Not Applicable | 00:00:45 | ---------------> This result is incorrect +-----------------------------------------------------------------+

Yes. I am looking into this issue

ZouYuhua added 3 commits May 23, 2024 13:31
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
Copy link
Collaborator Author

ZouYuhua commented May 23, 2024

@keirazhang
passed the testing for Freebsd 13 & 14 32bit. Thanks for your codereview.

Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ZouYuhua ZouYuhua merged commit 409a1ff into vmware:main May 23, 2024
@ZouYuhua ZouYuhua deleted the fix_zouy_freebsd14_64_autoinstall branch May 23, 2024 07:29
@keirazhang keirazhang added this to the 3.2 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants