Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Update Photon OS GPG key file to 4096 bit #581

Merged
merged 2 commits into from
May 28, 2024

Conversation

keirazhang
Copy link
Contributor

Photon OS package installation requires 4096 bit GPG key now, otherwise it will led to package installation failures like below:

    "invocation": {
        "module_args": {
            "_raw_params": "tdnf install -y cloud-init",
            "_uses_shell": false,
            "argv": null,
            "chdir": null,
            "creates": null,
            "executable": null,
            "removes": null,
            "stdin": null,
            "stdin_add_newline": true,
            "strip_empty_ends": true
        }
    },
    "msg": "non-zero return code",
    "rc": 234,

   ...

    "stdout_lines": [
        "",
        "Installing:",
        "lzo                      x86_64       2.10-1.ph4       photon       143.85k 147304",
        "python3-pyserial         noarch       3.5-1.ph4        photon       853.34k 873822",
        "btrfs-progs              x86_64       5.7-3.ph4        photon         4.88M 5122206",
        "",
        "Total installed size:   5.86M 6143332",
        "",
        "Upgrading:",
        "cloud-init               noarch       24.1.4-1.ph4     photon         5.92M 6211808",
        "",
        "Total installed size:   5.92M 6211808",
        "",
        "Downloading:",
        "",
        "",
        "",
        "",
        "importing key from file:///etc/pki/rpm-gpg/VMWARE-RPM-GPG-KEY"
    ]

This fix is followed Photon OS team's guidance to fetch 4096 bit GPG key and then update it to repo files:

    "invocation": {
        "module_args": {
            "_raw_params": "tdnf install -y cloud-init",
            "_uses_shell": false,
            "argv": null,
            "chdir": null,
            "creates": null,
            "executable": null,
            "removes": null,
            "stdin": null,
            "stdin_add_newline": true,
            "strip_empty_ends": true
        }
    },
    "msg": "",
    "rc": 0,

     ...

    "stdout_lines": [
        "",
        "Installing:",
        "lzo                      x86_64       2.10-1.ph4       photon       143.85k 147304",
        "python3-pyserial         noarch       3.5-1.ph4        photon       853.34k 873822",
        "btrfs-progs              x86_64       5.7-3.ph4        photon         4.88M 5122206",
        "",
        "Total installed size:   5.86M 6143332",
        "",
        "Upgrading:",
        "cloud-init               noarch       24.1.4-1.ph4     photon         5.92M 6211808",
        "",
        "Total installed size:   5.92M 6211808",
        "",
        "Downloading:",
        "",
        "",
        "",
        "",
        "importing key from file:///etc/pki/rpm-gpg/VMWARE-RPM-GPG-KEY",
        "importing key from file:///etc/pki/rpm-gpg/VMWARE-RPM-GPG-KEY-4096",
        "Testing transaction",
        "Running transaction",
        "Installing/Updating: python3-pyserial-3.5-1.ph4.noarch",
        "Installing/Updating: lzo-2.10-1.ph4.x86_64",
        "Installing/Updating: btrfs-progs-5.7-3.ph4.x86_64",
        "Installing/Updating: cloud-init-24.1.4-1.ph4.noarch",
        "Removing: cloud-init-21.4-2.ph4.noarch",
        "",
        "Complete!"
    ]
}

@keirazhang keirazhang added this to the 3.2 milestone May 24, 2024
@keirazhang keirazhang changed the title Update Photon OS GPG key file to 4096 bit [Linux] Update Photon OS GPG key file to 4096 bit May 24, 2024
@keirazhang keirazhang force-pushed the fix_photon_gpg_key branch from b4ade26 to 13ba50f Compare May 24, 2024 02:42
@keirazhang
Copy link
Contributor Author

Test passed on Photon OS 5.0, 4.0 and 3.0.

  - 'Guest os distribution: VMware Photon OS 5.0 x86_64'
  - 'Results: Total (6), Passed (4), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * ovt_verify_pkg_install..........................................Passed'
  - ' * gosc_perl_dhcp..........................................Not Applicable'
  - ' * gosc_perl_staticip......................................Not Applicable'
  - ' * gosc_cloudinit_dhcp.............................................Passed'
  - ' * gosc_cloudinit_staticip.........................................Passed'

  - 'Guest os distribution: VMware Photon OS 4.0 x86_64'
  - 'Results: Total (6), Passed (4), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * ovt_verify_pkg_install..........................................Passed'
  - ' * gosc_perl_dhcp..........................................Not Applicable'
  - ' * gosc_perl_staticip......................................Not Applicable'
  - ' * gosc_cloudinit_dhcp.............................................Passed'
  - ' * gosc_cloudinit_staticip.........................................Passed'

  - 'Guest os distribution: VMware Photon OS 3.0 x86_64'
  - 'Results: Total (6), Passed (4), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * ovt_verify_pkg_install..........................................Passed'
  - ' * gosc_perl_dhcp..........................................Not Applicable'
  - ' * gosc_perl_staticip......................................Not Applicable'
  - ' * gosc_cloudinit_dhcp.............................................Passed'
  - ' * gosc_cloudinit_staticip.........................................Passed'

Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
@keirazhang keirazhang force-pushed the fix_photon_gpg_key branch from 2976c29 to b8ef418 Compare May 27, 2024 06:26
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit 85dfb78 into vmware:main May 28, 2024
@keirazhang keirazhang deleted the fix_photon_gpg_key branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants