Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct guest info guest id in results.log and guest_info.json #583

Merged
merged 1 commit into from
May 28, 2024

Conversation

keirazhang
Copy link
Contributor

With latest VMTools, the guest id in guest info for MIRACL LINUX 9.2 is empty string, but in our results.log it is not. By checking log plugin, it erased all empty values. So this fix is to correct that. All facts will take the last value as its final value, no matter it is empty or not.

+------------------------------------------------------------------------------------------------------------+
| Config Guest Id           | asianux8_64Guest                                                               |
+------------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Id        |                                                                                |
+------------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Linux 5.14.0-284.11.1.el9_2.x86_64 MIRACLE LINUX 9.2 (Feige) 9.2 MIRACLE LINUX |
|                           | 9.2 (Feige) cpe:/o:cybertrust_japan:miracle_linux:9                            |
+------------------------------------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                                                     |
+------------------------------------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                                             |
|                           | bitness='64'                                                                   |
|                           | cpeString='cpe:/o:cybertrust_japan:miracle_linux:9'                            |
|                           | distroAddlVersion='9.2 (Feige)'                                                |
|                           | distroName='MIRACLE LINUX'                                                     |
|                           | distroVersion='9.2'                                                            |
|                           | familyName='Linux'                                                             |
|                           | kernelVersion='5.14.0-284.11.1.el9_2.x86_64'                                   |
|                           | prettyName='MIRACLE LINUX 9.2 (Feige)'                                         |
+------------------------------------------------------------------------------------------------------------+

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:06:40)
+--------------------------------------------------+
| ID | Name                   | Status | Exec Time |
+--------------------------------------------------+
|  1 | ovt_verify_pkg_install | Passed | 00:06:20  |
+--------------------------------------------------+

Signed-off-by: Qi Zhang <qi-keira.zhang@broadcom.com>
@keirazhang keirazhang added this to the 3.2 milestone May 28, 2024
@keirazhang keirazhang requested a review from Tomorrow9 May 28, 2024 03:18
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@keirazhang keirazhang merged commit 09fadf1 into vmware:main May 28, 2024
@keirazhang keirazhang deleted the fix_results_guestinfo branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants