Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] fix issue in win_get_driver_installer.yml #586

Merged
merged 1 commit into from
May 30, 2024

Conversation

Tomorrow9
Copy link
Member

"Get-ItemPropertyValue" was changed to "reg query" in former merge request, so that changing the result handling for getting the list of driver installers.

Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9 Tomorrow9 added this to the 3.2 milestone May 30, 2024
@Tomorrow9
Copy link
Member Author

TASK [Display the PowerShell command result] ***********************************
task path: /home/worker/workspace/Ansible_Windows_Server_LTSC_70U3_LSILOGICSAS_E1000E_EFI_SecureBoot/ansible-vsphere-gos-validation/windows/utils/win_execute_cmd.yml:53
ok: [localhost] => {
    "win_powershell_cmd_output": {
        "changed": true,
        "cmd": "if ($(Test-Path -Path \"HKLM:\\System\\CurrentControlSet\\Services\\pvscsi\")) {\n  reg query \"HKLM\\System\\CurrentControlSet\\Services\\pvscsi\" /v 'vwdk.installers' | findstr 'REG'\n}",
        "delta": "0:00:00.746758",
        "end": "2024-05-29 07:52:01.424962",
        "failed": false,
        "rc": 0,
        "start": "2024-05-29 07:52:00.678203",
        "stderr": "",
        "stderr_lines": [],
        "stdout": "    vwdk.installers    REG_MULTI_SZ    Windows\\0MSI\r\n",
        "stdout_lines": [
            "    vwdk.installers    REG_MULTI_SZ    Windows\\0MSI"
        ]
    }
}

TASK [Set fact of the driver installer info list] ******************************
task path: /home/worker/workspace/Ansible_Windows_Server_LTSC_70U3_LSILOGICSAS_E1000E_EFI_SecureBoot/ansible-vsphere-gos-validation/windows/utils/win_get_driver_installer.yml:36
ok: [localhost] => {
    "ansible_facts": {
        "win_driver_installer_list": [
            "Windows",
            "MSI"
        ]
    },
    "changed": false
}
...
TASK [Display the PowerShell command result] ***********************************
task path: /home/worker/workspace/Ansible_Windows_Server_LTSC_70U3_LSILOGICSAS_E1000E_EFI_SecureBoot/ansible-vsphere-gos-validation/windows/utils/win_execute_cmd.yml:53
ok: [localhost] => {
    "win_powershell_cmd_output": {
        "changed": true,
        "cmd": "if ($(Test-Path -Path \"HKLM:\\System\\CurrentControlSet\\Services\\vmxnet3ndis6\")) {\n  reg query \"HKLM\\System\\CurrentControlSet\\Services\\vmxnet3ndis6\" /v 'vwdk.installers' | findstr 'REG'\n}",
        "delta": "0:00:00.553622",
        "end": "2024-05-29 07:52:08.111434",
        "failed": false,
        "rc": 0,
        "start": "2024-05-29 07:52:07.557811",
        "stderr": "",
        "stderr_lines": [],
        "stdout": "    vwdk.installers    REG_MULTI_SZ    MSI\r\n",
        "stdout_lines": [
            "    vwdk.installers    REG_MULTI_SZ    MSI"
        ]
    }
}

TASK [Set fact of the driver installer info list] ******************************
task path: /home/worker/workspace/Ansible_Windows_Server_LTSC_70U3_LSILOGICSAS_E1000E_EFI_SecureBoot/ansible-vsphere-gos-validation/windows/utils/win_get_driver_installer.yml:36
ok: [localhost] => {
    "ansible_facts": {
        "win_driver_installer_list": [
            "MSI"
        ]
    },
    "changed": false
}

Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Tomorrow9 Tomorrow9 merged commit 091f038 into vmware:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants