Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FreeBSD 14] Missing the desktop cause the failure of testcase ovt_verify_status at detecting vmtoolsd user process #587

Merged
merged 9 commits into from
Jun 5, 2024
Merged

[FreeBSD 14] Missing the desktop cause the failure of testcase ovt_verify_status at detecting vmtoolsd user process #587

merged 9 commits into from
Jun 5, 2024

Conversation

ZouYuhua
Copy link
Collaborator

@ZouYuhua ZouYuhua commented Jun 4, 2024 •
edited
Loading

Description
testcase ovt_verify_status is failed at detecting vmtoolsd user process

Root Cause
It's because the Xserver is failed to bootup which caused by failure to install package xf86-video-vmware at autoinstall.

Test result
Passed to rerun all the failure async pacakges
image

ZouYuhua added 2 commits June 3, 2024 15:29
@ZouYuhua
Desktop env is not bootup as expected
8b44ea7 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
Desktop env is not bootup as expected
337d878 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
keirazhang
keirazhang reviewed Jun 4, 2024
View reviewed changes
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
ZouYuhua added 2 commits June 4, 2024 11:02
@ZouYuhua
change code as codereview
7651091 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
change code as codereview
ada90cb 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
keirazhang
keirazhang reviewed Jun 4, 2024
View reviewed changes
autoinstall/FreeBSD/14/installerconfig Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
autoinstall/FreeBSD/14/installerconfig Outdated Show resolved Hide resolved
ZouYuhua added 3 commits June 4, 2024 13:42
@ZouYuhua
change code as codereview
388ea01 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
change code as codereview
79b5012 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
change code as codereview
c151157 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
Copy link
Collaborator Author

ZouYuhua commented Jun 4, 2024

@keirazhang

Testing passed after code change:
image

@keirazhang
Copy link
Contributor

keirazhang commented Jun 4, 2024 •
edited by ZouYuhua
Loading

The variable reference didn't work .... You may try replace single quote with double quote. And please check the serial log carefully and make sure your changes take effect.

Install package $packages_to_install ...

To install the following packages from offical repo:  $packages_to_install xf86-video-vmware open-vm-tools xf86-input-vmmouse
Install package $packages_to_install (try 1 time) ...
Install package $packages_to_install (try 2 time) ...
Install package $packages_to_install (try 3 time) ...
Install package $packages_to_install (try 4 time) ...
Install package $packages_to_install (try 5 time) ...
Install package $packages_to_install (try 6 time) ...
Install package $packages_to_install (try 7 time) ...
Install package $packages_to_install (try 8 time) ...
Install package $packages_to_install (try 9 time) ...
Error: Failed to install $packages_to_install from ISO and online repo

Thanks. Running the full testcases after code change .....

ZouYuhua added 2 commits June 4, 2024 16:05
@ZouYuhua
change code as codereview
efbac8a 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
change code as codereview
a780aaa 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
keirazhang
keirazhang approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ZouYuhua ZouYuhua merged commit 90ca87c into vmware:main Jun 5, 2024
@ZouYuhua ZouYuhua deleted the fix_zouy_freebsd_14_desktop_issue branch June 5, 2024 01:42
@Tomorrow9 Tomorrow9 added this to the 3.2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ZouYuhua @keirazhang @Tomorrow9