Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install #590

Merged
merged 3 commits into from
Jun 14, 2024
Merged

[OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install #590

merged 3 commits into from
Jun 14, 2024

Conversation

ZouYuhua
Copy link
Collaborator

Two issue:

  1. ovt_verify_pkg_install failed due to running /usr/lib/packagekitd on opensuse-15.6-GA-64bit
  2. undefined variable is reported in ovt_verify_pkg_install on opensuse-15.6-GA-64bit

Test result:

  1. pass the testing for issue 1:
image
  1. The testing is on-going for issue 2

ZouYuhua added 2 commits June 13, 2024 15:20
@ZouYuhua
fix ovt_verify_pkg_install issue for opensusu
6c962ef 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
fix undefined variable
6ba74a3 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
@ZouYuhua
change code as codereview
bb085c8 
Signed-off-by: ZouYuhua <yuhua.zou@broadcom.com>
keirazhang
keirazhang approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ZouYuhua ZouYuhua changed the title [WIP:][OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install [OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install Jun 14, 2024
@ZouYuhua ZouYuhua merged commit 94c0049 into vmware:main Jun 14, 2024
@keirazhang keirazhang added this to the 3.2 milestone Jun 14, 2024
@ZouYuhua ZouYuhua deleted the fix_zouy_opensuse branch June 14, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ZouYuhua @keirazhang