Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add new test case windows_online_updates_install #594

Merged
merged 22 commits into from
Jul 3, 2024
Merged

[Windows] Add new test case windows_online_updates_install #594

merged 22 commits into from
Jul 3, 2024

Conversation

Tomorrow9
Copy link
Member

@Tomorrow9 Tomorrow9 commented Jun 19, 2024 •
edited
Loading

Add a new parameter 'windows_updated_build_num', which is the at least build number user expected after installing Windows updates.

windows_updated_build_num is not defined or empty or is the same as the current build:
Running this test case, means installing available Windows updates, and will not compare the build number after.
If no updates searched, test case will be skipped.

windows_updated_build_num is defined and newer than the current build:
Running this test case, means installing available Windows updates containing categories which will increase the build num, and will check build number after installing updates should >= expected build number.

windows_updated_build_num is defined and older than the current build:
test case will fail due to incorrect parameter configuration.

@Tomorrow9 Tomorrow9 added this to the 3.2 milestone Jun 19, 2024
@Tomorrow9 Tomorrow9 marked this pull request as draft June 19, 2024 08:14
keirazhang
keirazhang reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this new case doing similar thing like windows_update_install/install_online_updates.yml. Can't it be reused with some modifications?

vars/test.yml Outdated Show resolved Hide resolved
windows/windows_online_updates_install/windows_online_updates_install.yml Outdated Show resolved Hide resolved
windows/windows_online_updates_install/windows_online_updates_install.yml Outdated Show resolved Hide resolved
@Tomorrow9
Copy link
Member Author

It seems this new case doing similar thing like windows_update_install/install_online_updates.yml. Can't it be reused with some modifications?

This new added test case windows_online_updates_install can be executed before test case windows_update_install (whose name can be improved later) to avoid same execution, and the modification can be evaluated after this test case merged. Thanks.

keirazhang
keirazhang reviewed Jun 21, 2024
View reviewed changes
vars/test.yml Outdated Show resolved Hide resolved
windows/utils/win_get_online_updates.yml Outdated Show resolved Hide resolved
windows/utils/win_pause_resume_win_update.yml Outdated Show resolved Hide resolved
windows/utils/win_pause_resume_win_update.yml Show resolved Hide resolved
@Tomorrow9 Tomorrow9 force-pushed the fix_win_online_update branch from 1f1d465 to 157f339 Compare June 25, 2024 08:02
@Tomorrow9 Tomorrow9 marked this pull request as ready for review June 27, 2024 07:58
@Tomorrow9 Tomorrow9 force-pushed the fix_win_online_update branch from a479a9a to a32d41a Compare June 28, 2024 06:24
keirazhang
keirazhang previously approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

keirazhang
keirazhang previously approved these changes Jun 28, 2024
View reviewed changes
123lzxm
123lzxm reviewed Jul 1, 2024
View reviewed changes
windows/utils/win_get_online_updates.yml Outdated Show resolved Hide resolved
windows/utils/win_install_online_updates.yml Show resolved Hide resolved
windows/utils/win_remove_windows_old.yml Outdated Show resolved Hide resolved
Tomorrow9 added 15 commits July 2, 2024 06:03
@Tomorrow9
add new test case windows_online_update
3434aa6 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add new test case windows_online_update
ed7fc64 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add test case for Windows online udpate
35ae29a 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
update test.yml
6b0f07f 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add check build
f544443 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add new test case windows_online_update
fd91da2 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix syntax issue
ef06793 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
check windows.old folder size
16acf6b 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add utilies for resuming Windows update
7cb84e7 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add resume windows update task
1843ac3 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add test case windows_online_update
d00ec2e 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add get Windows updates retries
00d12ff 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add new test case windows_online_updates_install
b94bc77 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
334a133 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
2306338 
Signed-off-by: Diane Wang <dianew@vmware.com>
Tomorrow9 added 7 commits July 2, 2024 06:03
@Tomorrow9
address comments
59a0d0c 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix syntax error
2b5c19a 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
fix syntax issue
500809b 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
a9614e9 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
add pause Windows update before basesnapshot reset
f1b8f2f 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
move new test case up
f70f7dd 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9
address comments
ec0954a 
Signed-off-by: Diane Wang <dianew@vmware.com>
@Tomorrow9 Tomorrow9 force-pushed the fix_win_online_update branch from 53fa4ea to ec0954a Compare July 2, 2024 06:04
123lzxm
123lzxm approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Tomorrow9 Tomorrow9 merged commit 816f89d into vmware:main Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm approved these changes

@keirazhang keirazhang keirazhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomorrow9 @keirazhang @123lzxm