Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoinstall support for Fedora Workstation #612

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

linhuali
Copy link
Collaborator

@linhuali linhuali commented Jul 16, 2024

  • Support autoinstall for Fedora Workstation with Fedora-Everything-netinst-.*.iso
  • Testing done for autoinstall with Fedora Workstation 39 and 40
  • Testing done for other ansible tests with Fedora Workstation 39 and 40
    • Fedora Workstation 40:
VM information:
+--------------------------------------------------------------------------------+
| Name                      | test_vm                                            |
+--------------------------------------------------------------------------------+
| Guest OS Distribution     | Fedora 40 x86_64                                   |
+--------------------------------------------------------------------------------+
| GUI Installed             | True                                               |
+--------------------------------------------------------------------------------+
| Hardware Version          | vmx-22                                             |
+--------------------------------------------------------------------------------+
| VMTools Version           | 12.4.0 (build-23259341)                            |
+--------------------------------------------------------------------------------+
| Config Guest Id           | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Id        | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Red Hat Fedora (64-bit)                            |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                         |
+--------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                 |
|                           | bitness='64'                                       |
|                           | cpeString='cpe:/o:fedoraproject:fedora:40'         |
|                           | distroAddlVersion='40 (Workstation Edition)'       |
|                           | distroName='Fedora Linux'                          |
|                           | distroVersion='40'                                 |
|                           | familyName='Linux'                                 |
|                           | kernelVersion='6.9.8-200.fc40.x86_64'              |
|                           | prettyName='Fedora Linux 40 (Workstation Edition)' |
+--------------------------------------------------------------------------------+

Test Results (Total: 31, Passed: 23, Skipped: 8, Elapsed Time: 02:10:20)
+-------------------------------------------------------------------------+
| ID | Name                                 |   Status        | Exec Time |
+-------------------------------------------------------------------------+
| 01 | deploy_vm_efi_lsilogic_vmxnet3       |   Passed        | 00:29:50  |
| 02 | check_inbox_driver                   |   Passed        | 00:01:49  |
| 03 | ovt_verify_pkg_install               |   Passed        | 00:07:12  |
| 04 | ovt_verify_status                    |   Passed        | 00:03:14  |
| 05 | vgauth_check_service                 |   Passed        | 00:01:12  |
| 06 | host_verify_saml_token               |   Passed        | 00:02:45  |
| 07 | check_ip_address                     |   Passed        | 00:01:01  |
| 08 | check_os_fullname                    |   Passed        | 00:01:37  |
| 09 | stat_balloon                         |   Passed        | 00:00:57  |
| 10 | stat_hosttime                        |   Passed        | 00:00:55  |
| 11 | device_list                          |   Passed        | 00:03:10  |
| 12 | check_quiesce_snapshot_custom_script |   Passed        | 00:01:30  |
| 13 | memory_hot_add_basic                 |   Passed        | 00:07:33  |
| 14 | cpu_hot_add_basic                    | * Not Supported | 00:00:01  |
| 15 | cpu_multicores_per_socket            |   Passed        | 00:09:16  |
| 16 | check_efi_firmware                   |   Passed        | 00:01:00  |
| 17 | secureboot_enable_disable            |   Passed        | 00:04:37  |
| 18 | e1000e_network_device_ops            |   Passed        | 00:04:36  |
| 19 | vmxnet3_network_device_ops           |   Passed        | 00:03:34  |
| 20 | pvrdma_network_device_ops            | * Not Supported | 00:00:52  |
| 21 | gosc_perl_dhcp                       | * Not Supported | 00:01:04  |
| 22 | gosc_perl_staticip                   | * Not Supported | 00:00:57  |
| 23 | gosc_cloudinit_dhcp                  | * Not Supported | 00:00:43  |
| 24 | gosc_cloudinit_staticip              | * Not Supported | 00:00:58  |
| 25 | paravirtual_vhba_device_ops          |   Passed        | 00:08:00  |
| 26 | lsilogic_vhba_device_ops             | * Not Supported | 00:00:55  |
| 27 | lsilogicsas_vhba_device_ops          | * Not Supported | 00:00:58  |
| 28 | sata_vhba_device_ops                 |   Passed        | 00:08:13  |
| 29 | nvme_vhba_device_ops                 |   Passed        | 00:08:12  |
| 30 | nvdimm_cold_add_remove               |   Passed        | 00:08:27  |
| 31 | ovt_verify_pkg_uninstall             |   Passed        | 00:03:46  |
+-------------------------------------------------------------------------+

@linhuali linhuali requested a review from keirazhang July 16, 2024 12:02
@linhuali linhuali self-assigned this Jul 16, 2024
@keirazhang
Copy link
Contributor

I saw Fedora workstation's pretty name has Workstation Edition keywords. Can you also update linux/utils/get_os_edition.yml to set guest_os_edition for Fedora? You can directly extract edition from guest_os_release.PRETTY_NAME (guest_os_release has been set in linux/utils/get_os_release.yml. For example,

# Get fedora edition
- set_fact:
      fedora_edition: "{{ guest_os_release.PRETTY_NAME | regex_search('(\\w+) Edition', '\\1', ignorecase=true) }}"

# Then set guest_os_edition:
- set_fact:
       guest_os_edition: "{{ fedora_edition | first }}"
   when: fedora_edition | length > 0

This should be put a block for Fedora and when guest_os_release.PRETTY_NAME is defined

@linhuali
Copy link
Collaborator Author

Fedora 40 Workstation:

+--------------------------------------------------------------------------------+
| Name                      | Fedora-Workstation-40-EFI-Open-VM-Tools            |
+--------------------------------------------------------------------------------+
| Guest OS Distribution     | Fedora 40 Workstation x86_64                       |
+--------------------------------------------------------------------------------+
| GUI Installed             | True                                               |
+--------------------------------------------------------------------------------+
| Hardware Version          | vmx-20                                             |
+--------------------------------------------------------------------------------+
| VMTools Version           | 12.4.0 (build-23259341)                            |
+--------------------------------------------------------------------------------+
| Config Guest Id           | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Id        | fedora64Guest                                      |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Red Hat Fedora (64-bit)                            |
+--------------------------------------------------------------------------------+
| GuestInfo Guest Family    | linuxGuest                                         |
+--------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                 |
|                           | bitness='64'                                       |
|                           | cpeString='cpe:/o:fedoraproject:fedora:40'         |
|                           | distroAddlVersion='40 (Workstation Edition)'       |
|                           | distroName='Fedora Linux'                          |
|                           | distroVersion='40'                                 |
|                           | familyName='Linux'                                 |
|                           | kernelVersion='6.9.9-200.fc40.x86_64'              |
|                           | prettyName='Fedora Linux 40 (Workstation Edition)' |
+--------------------------------------------------------------------------------+

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:26:10)
+-------------------------------------------------------------+
| ID | Name                              | Status | Exec Time |
+-------------------------------------------------------------+
|  1 | deploy_vm_efi_paravirtual_vmxnet3 | Passed | 00:25:49  |
+-------------------------------------------------------------+

Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@keirazhang keirazhang added this to the 3.2 milestone Jul 18, 2024
linhuali added 3 commits July 18, 2024 06:04
Signed-off-by: linhuali <lli@vmware.com>
Signed-off-by: linhuali <lli@vmware.com>
Signed-off-by: linhuali <lli@vmware.com>
@linhuali linhuali force-pushed the fix_fedora_workstation branch from b407f7f to 56fc085 Compare July 18, 2024 06:05
@linhuali linhuali merged commit 7f6a228 into vmware:main Jul 18, 2024
@linhuali linhuali deleted the fix_fedora_workstation branch July 18, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants