Feature angular upgrade edwardpei #885
Conversation
Signed-off-by: kuo Pei <kpei@vmware.com>
Signed-off-by: kuo Pei <kpei@vmware.com>
Signed-off-by: kuo Pei <kpei@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
============================================
+ Coverage 41.74% 41.78% +0.04%
+ Complexity 1580 1533 -47
============================================
Files 233 233
Lines 12891 12878 -13
Branches 1727 1721 -6
============================================
Hits 5381 5381
+ Misses 6823 6817 -6
+ Partials 687 680 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -11,7 +11,6 @@ | |||
| "build": { | |||
| "builder": "@angular-devkit/build-angular:browser", | |||
| "options": { | |||
| "aot": true, | |||
There was a problem hiding this comment.
Any reason we remove this flag?
| ] | ||
| ], | ||
| "vendorChunk": true, | ||
| "extractLicenses": false, |
There was a problem hiding this comment.
We should include the licenses of third part project.
| ], | ||
| "vendorChunk": true, | ||
| "extractLicenses": false, | ||
| "buildOptimizer": false, |
There was a problem hiding this comment.
Can you share the reason to set this flag as false?
| @@ -11,4 +11,4 @@ export const ROUTES: Routes = [ | |||
| {path:'ui/nav', loadChildren: () => import('app/pages/nav/nav.module').then(m => m.NavModule),canActivate: [CanActivateAuthGuard]} | |||
| ]; | |||
|
|
|||
| export const ROUTING: ModuleWithProviders<RouterModule> = RouterModule.forRoot(ROUTES,{ useHash: false }); | |||
| export const ROUTING: ModuleWithProviders<RouterModule> = RouterModule.forRoot(ROUTES,{ useHash: false, relativeLinkResolution: 'legacy' }); | |||
There was a problem hiding this comment.
Can you estimate the effort needed to use relativeLinkResolution=correct ?
|
We remove this file a few months before.
|
Will add lock file later/or when we create a release.
|
@KpeiVM, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
upgrade angular from 10 to 13