Remove CloseMsgChan() method from collector process #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a seprate method to close an "output" channel is an anti-pattern IMO, and it is not clear how library consumers are supposed to use it, in particular in relation to the Stop() method. Instead, we can close the channel when the Stop() method is closed, and all goroutines which may write to the channel have been stopped. Goroutines which read from the channel can use this as a signal to stop - or can be signalled directly by the goroutine which called Stop() in the first place. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
deleted the
remove-CloseMsgChan-method-from-collector-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a seprate method to close an "output" channel is an anti-pattern IMO, and it is not clear how library consumers are supposed to use it, in particular in relation to the Stop() method.
Instead, we can close the channel when the Stop() method is closed, and all goroutines which may write to the channel have been stopped. Goroutines which read from the channel can use this as a signal to stop - or can be signalled directly by the goroutine which called Stop() in the first place.