Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depending on unspecified behavior #3112

Closed
zigo101 opened this issue Apr 26, 2023 · 11 comments · Fixed by #3585
Closed

depending on unspecified behavior #3112

zigo101 opened this issue Apr 26, 2023 · 11 comments · Fixed by #3585
Assignees
@tenthirtyam

Comments

@zigo101
Copy link

zigo101 commented Apr 26, 2023

https://github.com/vmware/govmomi/blob/main/vapi/tags/categories.go#L93-L94

More details: golang/go#58233 (comment)
@github-actions
Copy link
Contributor

Howdy 🖐   go101 ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@zigo101
Copy link
Author

zigo101 commented Jul 26, 2023

/remove-lifecycle stale

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@zigo101
Copy link
Author

zigo101 commented Oct 26, 2023

/remove-lifecycle stale

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@zigo101
Copy link
Author

zigo101 commented Jan 25, 2024

/remove-lifecycle stale

@dependabot dependabot bot mentioned this issue Feb 6, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@zigo101
Copy link
Author

zigo101 commented Apr 26, 2024

/remove-lifecycle stale

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@zigo101
Copy link
Author

zigo101 commented Jul 27, 2024

/remove-lifecycle stale

@tenthirtyam tenthirtyam self-assigned this Oct 7, 2024
tenthirtyam added a commit that referenced this issue Oct 7, 2024
@tenthirtyam
api: tags error handling
b7305f5 
Checks if `err` is not `nil` after calling `c.Do`. If an error occurs, it returns `nil` and the error. If no error occurs, it returns the `nil` or the result and `nil` depending on the function.

This ensures that the functions handle errors gracefully and avoids unspecified behavior during the return process.

Ref: #3112

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam mentioned this issue Oct 7, 2024
Merged
@tenthirtyam tenthirtyam changed the title [BUG] Unprofessional code depending on unspecified behavior depending on unspecified behavior Oct 7, 2024
tenthirtyam added a commit that referenced this issue Oct 8, 2024
@tenthirtyam
api: tags error handling
d14cbf3 
Checks if `err` is not `nil` after calling `c.Do`. If an error occurs, it returns `nil` and the error. If no error occurs, it returns the `nil` or the result and `nil` depending on the function.

This ensures that the functions handle errors gracefully and avoids unspecified behavior during the return process.

Ref: #3112

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenthirtyam tenthirtyam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: tags error handling vmware/govmomi
2 participants
@tenthirtyam @zigo101