Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: vSphere 8.0U2 GA & add code comments / min API version info to/for EAM/PBM/SMS/VSLM API data structs / fields / enums / enum values #3236

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

akutz
Copy link
Member

@akutz akutz commented Sep 22, 2023

Description

This PR updates the generated types to vSphere 8.0U2 GA. Additionally, all EAM/PBM/SMS/VSLM API data structures, their fields, enums, and enum values include:

  • Code comments
  • Support for discovering the API version for which the symbol was introduced:
    • For struct fields this is via a Go field tag named vim.
    • For types this is via the new registry minAPIVersionForType
    • For enum values this is via the new registry minAPIVersionForEnumValue

Closes: NA

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Relying on the PR tests.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

This patch updates the gen.sh file with the information necessary to
generate the types for vSphere 8.0U2 GA.
@akutz akutz force-pushed the feature/8.0U2 branch 2 times, most recently from 11734bf to dda2d44 Compare September 22, 2023 20:19
This patch updates the generated types to vSphere 8.0U2 GA.
@akutz akutz changed the title api: vSphere 8.0U2 GA & add code comments / min API version info to/for EAM API data structs / fields / enums / enum values api: vSphere 8.0U2 GA & add code comments / min API version info to/for EAM/PBM/SMS/VSLM API data structs / fields / enums / enum values Sep 22, 2023
@akutz akutz force-pushed the feature/8.0U2 branch 2 times, most recently from c27bee9 to f185da6 Compare September 23, 2023 00:10
dougm
dougm previously approved these changes Sep 23, 2023
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akutz !

This patch addresses a build error after the update to 8.0U2 GA.
The VSLM client was using an invalid API syntax. Additionally,
there was a fix for the change from the "mo" field tag to using
"json" instead.
@akutz
Copy link
Member Author

akutz commented Sep 25, 2023

Hey @dougm,

I need another review since pushing the patch dismissed the previous review.

Copy link
Contributor

@karaatanassov karaatanassov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Andrew. This is of great help. govmomi will be so much more useful now.

@akutz akutz merged commit 9d6dca6 into vmware:main Sep 25, 2023
10 checks passed
@akutz akutz deleted the feature/8.0U2 branch September 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants