-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcsim: Support PlaceVm with relocate placement type #3546
vcsim: Support PlaceVm with relocate placement type #3546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yanleizhao-vmware , lgtm. Just a couple minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yanleizhao-vmware ,
Can you please squash the review fixup commits first?
Of course, I wasn't sure if using squash and fixup is recommended, or tolerated 😅 |
This patch introduces basic support for `ClusterComputeResource.PlaceVm` with the `relocate` placement type in vcsim. Since relocate is a supported placement type in real vSphere environments, it is essential to ensure that our simulator environment reflects this capability for accurate and comprehensive testing.
4e50ee8
to
8421b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yanleizhao-vmware !
Description
This patch introduces basic support for
ClusterComputeResource.PlaceVm
with therelocate
placement type in vcsim. Since relocate is a supported placement type in real vSphere environments, it is essential to ensure that our simulator environment reflects this capability for accurate and comprehensive testing.Closes: #3540
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
All of the added unit tests simulate behavior (i.e., expected Faults/Recommendations) when testing the same
PlacementSpec
against a real vSphere environment.100% code coverage on new code:
Checklist:
CONTRIBUTION
guidelines of this project