Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add controller type check in simulator configureDevice #3591

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: add controller type check in simulator configureDevice #3591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions simulator/virtual_machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,11 +1289,13 @@ func (vm *VirtualMachine) configureDevice(
// Update device controller's key reference
if key != d.Key {
if device := devices.FindByKey(d.ControllerKey); device != nil {
c := device.(types.BaseVirtualController).GetVirtualController()
for i := range c.Device {
if c.Device[i] == key {
c.Device[i] = d.Key
break
if c, ok := device.(types.BaseVirtualController); ok {
c := c.GetVirtualController()
for i := range c.Device {
if c.Device[i] == key {
c.Device[i] = d.Key
break
}
}
}
}
Expand Down
Loading