Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique version names in multiple versions' key API #2812

Merged

Conversation

Xiaochao8
Copy link
Contributor

No description provided.

@Xiaochao8 Xiaochao8 enabled auto-merge (squash) November 9, 2023 08:37
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ebdf534) 79.75% compared to head (d0e60a3) 79.59%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           g11n-go-service    #2812      +/-   ##
===================================================
- Coverage            79.75%   79.59%   -0.16%     
===================================================
  Files                   56       56              
  Lines                 3057     3058       +1     
===================================================
- Hits                  2438     2434       -4     
- Misses                 504      510       +6     
+ Partials               115      114       -1     
Flag Coverage Δ
coverage 79.59% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/v2/translation/handler_trans.go 71.42% <0.00%> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiaochao8 Xiaochao8 merged commit b61ecc2 into vmware:g11n-go-service Nov 20, 2023
20 checks passed
@Xiaochao8 Xiaochao8 deleted the g11n-go-service_multiversions_key_1 branch November 20, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants