G11n java client - New caching workflow #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://sonarcloud.io/project/issues?id=jessiejuachon-java-client-g11n-java-client&issues=AXDG68NFL24bPpi-pS5s&open=AXDG68NFL24bPpi-pS5s https://sonarcloud.io/project/issues?id=jessiejuachon-java-client-g11n-java-client&issues=AXDG68IGL24bPpi-pS2r&open=AXDG68IGL24bPpi-pS2r Signed-off-by: Jessie <jessiejuachon@gmail.com>
linr211
reviewed
Mar 12, 2020
Signed-off-by: Jessie <jessiejuachon@gmail.com>
…and return them upstream.
linr211
reviewed
Mar 16, 2020
Xiaochao8
reviewed
Mar 18, 2020
src/main/java/com/vmware/vipclient/i18n/messages/service/ComponentsService.java
Outdated
Show resolved
Hide resolved
Xiaochao8
previously approved these changes
Mar 20, 2020
src/main/java/com/vmware/vipclient/i18n/messages/service/ComponentService.java
Outdated
Show resolved
Hide resolved
linr211
previously approved these changes
Mar 24, 2020
Xiaochao8
previously approved these changes
Mar 25, 2020
…t in order to get a 304 NOT MODIFIED http response
… is stored but has a null value
Xiaochao8
reviewed
Apr 8, 2020
src/main/java/com/vmware/vipclient/i18n/messages/service/StringService.java
Outdated
Show resolved
Hide resolved
…dded to each specific request locally.
Xiaochao8
reviewed
Apr 8, 2020
src/main/java/com/vmware/vipclient/i18n/messages/service/CacheService.java
Show resolved
Hide resolved
src/main/java/com/vmware/vipclient/i18n/messages/service/StringService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/vmware/vipclient/i18n/base/cache/MessageCache.java
Outdated
Show resolved
Hide resolved
Xiaochao8
reviewed
Apr 8, 2020
src/main/java/com/vmware/vipclient/i18n/base/HttpRequester.java
Outdated
Show resolved
Hide resolved
src/main/java/com/vmware/vipclient/i18n/base/HttpRequester.java
Outdated
Show resolved
Hide resolved
Xiaochao8
reviewed
Apr 9, 2020
src/main/java/com/vmware/vipclient/i18n/base/cache/CacheItem.java
Outdated
Show resolved
Hide resolved
linr211
reviewed
Apr 9, 2020
src/main/java/com/vmware/vipclient/i18n/base/cache/CacheItem.java
Outdated
Show resolved
Hide resolved
Xiaochao8
reviewed
Apr 10, 2020
Xiaochao8
reviewed
Apr 10, 2020
src/main/java/com/vmware/vipclient/i18n/messages/service/CacheService.java
Show resolved
Hide resolved
linr211
reviewed
Apr 10, 2020
src/main/java/com/vmware/vipclient/i18n/base/cache/TranslationCacheManager.java
Outdated
Show resolved
Hide resolved
src/test/java/com/vmware/vipclient/i18n/messages/service/CacheServiceTest.java
Show resolved
Hide resolved
linr211
previously approved these changes
Apr 11, 2020
Xiaochao8
approved these changes
Apr 11, 2020
Xiaochao8
suggested changes
Apr 11, 2020
src/main/java/com/vmware/vipclient/i18n/messages/api/opt/server/ComponentBasedOpt.java
Outdated
Show resolved
Hide resolved
Xiaochao8
approved these changes
Apr 14, 2020
linr211
approved these changes
Apr 14, 2020
jessiejuachon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this API to load configuration from a JSON configuration file.
The JSON schema shall be common across all supported client libraries.
The content of the sample config file will be enhanced later.
Have also pushed changes for adding a map of cache properties (e.g. etag, cache-control).
Marked the services (LocaleService, ComponentService, etc) with TODO to indicate unimplemented fetching of these cache properties from the http response.