Error logging for Unsuccessful L10n Fetch ( plus code clean up) #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://sonarcloud.io/project/issues?id=jessiejuachon-java-client-g11n-java-client&issues=AXDG68NFL24bPpi-pS5s&open=AXDG68NFL24bPpi-pS5s https://sonarcloud.io/project/issues?id=jessiejuachon-java-client-g11n-java-client&issues=AXDG68IGL24bPpi-pS2r&open=AXDG68IGL24bPpi-pS2r Signed-off-by: Jessie <jessiejuachon@gmail.com>
Signed-off-by: Jessie <jessiejuachon@gmail.com>
…and return them upstream.
…t in order to get a 304 NOT MODIFIED http response
…ne if component locale's cache has expired
…ingleton into g11n-java-client
…using cacheExpiredTime config
…g file. This means max age from server will be used. Setting VIPCfg.cacheExpiredTime to 0 disables caching.
…t need to be maintained.
Signed-off-by: Jessie <jessiejuachon@gmail.com>
…ales for offline mode; fixing some bugs in getting supported locales
…/LocalLocaleOpt.java Co-authored-by: Xiaochao Li <48587632+Xiaochao8@users.noreply.github.com>
…/LocalLocaleOpt.java Co-authored-by: Xiaochao Li <48587632+Xiaochao8@users.noreply.github.com>
…into g11n-java-client
Xiaochao8
reviewed
May 8, 2020
src/main/java/com/vmware/vipclient/i18n/messages/api/opt/server/ComponentBasedOpt.java
Outdated
Show resolved
Hide resolved
linr211
reviewed
May 8, 2020
src/main/java/com/vmware/vipclient/i18n/util/ConstantsKeys.java
Outdated
Show resolved
Hide resolved
Xiaochao8
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.