Fix Windows bug on getComponentMessages #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/LocalMessagesOpt.java Co-authored-by: Xiaochao Li <48587632+Xiaochao8@users.noreply.github.com>
…into non-block-cache
jessiejuachon
added
kind/bug
Xiaochao8
approved these changes
Dec 8, 2020
huihuiw01
reviewed
Dec 8, 2020
| Path path = Paths.get(VIPCfg.getInstance().getOfflineResourcesBaseUrl(), filePath); | ||
| InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream(path.toString()); | ||
| String offlineResourcePath = VIPCfg.getInstance().getOfflineResourcesBaseUrl(); | ||
| if(!offlineResourcePath.endsWith("/")) |
There was a problem hiding this comment.
Can "/" be suitable for all systems? Should it be FileSeparator?
There was a problem hiding this comment.
No, that is the root cause of the bug. If we use FileSeparator (same as Paths.get), then '' (backslash) will be used in Windows platform. However, the forward slash in jar is not platform dependent. Even if the application is run on a Windows platform, the jar files will still have forward slashes. The use of Paths.get (or FileSeparator) was causing the issue of not finding the message bundles.
huihuiw01
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths.get must not be use here because the defined path separator in JAR files is '/' (forward slash). Paths.get will use '' (backslash) in Windows which results to not finding the messages_xx.json path inside the jar.