Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update copyright and spdx #1420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Oct 12, 2024

Summary of Pull Request

As discussed with Chip Childers:

  • Updates or adds the Broadcom copyright, as needed.
  • Updates or adds the SPDX-License-Identifier, as needed.
  • Removes whitespace as noted.

Go:

// © Broadcom. All Rights Reserved.
// The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
// SPDX-License-Identifier: MPL-2.0

Python:

# © Broadcom. All Rights Reserved.
# The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
# SPDX-License-Identifier: MPL-2.0

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the chore Chore label Oct 12, 2024
@tenthirtyam tenthirtyam requested a review from annakhm October 12, 2024 03:14
@tenthirtyam tenthirtyam self-assigned this Oct 12, 2024
@tenthirtyam tenthirtyam added needs-review Needs Review size/l Relative Sizing: large labels Oct 12, 2024
main.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam force-pushed the chore/update-copyright-and-spdx branch 3 times, most recently from cd67b5f to b13df72 Compare October 14, 2024 15:08
@tenthirtyam tenthirtyam requested a review from ksamoray October 14, 2024 15:09
tools/terragen.py Outdated Show resolved Hide resolved
@ksamoray
Copy link
Collaborator

@tenthirtyam note that we have a feature branch, vpc20-feature-branch, which adds a whole bunch of other files which should be modified as well.
IDK what's the best approach here - wait with such change until we merge vpc20-feature-branch into master, modify the addl files in the feature branch or cherry-pick this into the feature branch... Maybe @annakhm or @salv-orlando have a suggestion here.

- Updates or adds the Broadcom copyright, as needed.
- Updates or adds the SPDX-License-Identifier, as needed.
- Removes whitespace as noted.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore/update-copyright-and-spdx branch from b13df72 to 4e60c2a Compare October 14, 2024 15:21
@tenthirtyam
Copy link
Collaborator Author

tenthirtyam commented Oct 14, 2024

Hey @ksamora - 👋 I'd suggest waiting until the vpc20-feature-branch branch is merged and we can then rebase this branch and update any additional files that need the updates from vpc20-feature-branch to keep in all in one related change.

Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review size/l Relative Sizing: large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants