Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant data source #1438

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove redundant data source #1438

merged 1 commit into from
Oct 21, 2024

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Oct 17, 2024

No description provided.

@annakhm
Remove redundant data source
01d21ad 
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
tenthirtyam
tenthirtyam reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend enhancing this pull request to put all resources and data sources in alphabetical order.

Duplicates will easier to spot and the code is more logically ordered and readable.

@annakhm
Copy link
Collaborator Author

annakhm commented Oct 17, 2024

Good point @tenthirtyam, however I'd rather postpone this one until after the Big Merge, to minimize merge errors

@tenthirtyam
Copy link
Collaborator

Totally understand!

salv-orlando
salv-orlando approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salv-orlando salv-orlando merged commit 87bec3a into vpc20-feature-branch Oct 21, 2024
3 checks passed
@salv-orlando salv-orlando deleted the merge-issue branch October 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthirtyam tenthirtyam tenthirtyam left review comments

@ksamoray ksamoray ksamoray approved these changes

@salv-orlando salv-orlando salv-orlando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annakhm @tenthirtyam @salv-orlando @ksamoray