refactor: removed resource wrapper #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored to use the context aware functions instead of the deprecated `schema.ReadFunc`. `schema.CreateFunc`, `schema.UpdateFunc`. and `schema.DeleteFunc` functions. Refactored to remove redundancy by creating a generic wrapper function that handles the common logic for all actions (read, create, update, delete). - Added a constant for the NSX version where the resource was removed rather than repeating it. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
| return originalFunc(d, m) | ||
|
|
||
| switch f := originalFunc.(type) { | ||
| case schema.ReadContextFunc: |
There was a problem hiding this comment.
@tenthirtyam the functions in provider resources do not implement the xxxContext functions. We are aware Read, Write, Update, and Deleted are deprecated in favor of xxxContext functions, but don't we have to change resources to implement these function to make the code work in this way?
| if commonVersionCheck(m) { | ||
| return originalFunc(d, m) | ||
|
|
||
| switch f := originalFunc.(type) { |
There was a problem hiding this comment.
Thanks for this. I could not get this cast to work properly, and this is why I did not implement a generic wrapper in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Refactored to use the context aware functions instead of the deprecated
schema.ReadFunc.schema.CreateFunc,schema.UpdateFunc. andschema.DeleteFuncfunctions.Refactored to remove redundancy by creating a generic wrapper function that handles the common logic for all actions (read, create, update, delete).
Type of Pull Request
Please describe:
Related to Existing Issues
Test and Documentation Coverage
For bug fixes or features:
Breaking Changes?