Merge branch 'feature/vic-machine-service' [full ci] #6665

zjs · 2017-10-31T17:22:43Z

Define a new VCH Management API and implement the subset of that API which is necessary for building a VCH Creation Wizard as a part of the H5 Client Plugin.

Fixes #5721

At this stage, review should focus on understanding this large change and identifying work which may need to be completed before the merge. Feedback raised as a part of this review will be separated out into new GitHub issues for tracking.

Instructions:

To build the API server locally, use make serviceapi.
- To run the resulting API server binary, see bin/vic-machine-server --help.
To build the container for the API server, see cmd/vic-machine-server/Dockerfile.
- To build an OVA which includes the container for the API server, see installer/BUILD.md in the vic-product repository.
For information on using this API, see Add tutorial for VCH Management API vic-product#1004.

Known remaining work:

Document the design for the vic-machine API #6702: Document the design for the vic-machine API (in review)
~~Add container-name-convention support to VCH creation API #6503: Add container-name-convention support to VCH creation API~~
~~vic-machine-server should generate request logs #6571: vic-machine-server should generate request logs~~
Expose "grant permissions" option for the operations credentials in the VCH creation API #6632: Expose "grant permissions" option for the operations credentials in the VCH creation API [ship stopper]
~~VCH Creation API: Add support for container network trust level #6740: VCH Creation API: Add support for container network trust level~~
~~Implement API handler for VCH deletion [specific ci=Group23-VIC-Machine-Service] #6694: Implement API handler for deletion of a VCH~~

Known testing gaps:

~~Implement unit tests for the API handler for creating a VCH #6018: Implement unit tests for the API handler for creating a VCH~~
~~Clean up VCH Management API robot tests [specific ci=Group23-VIC-Machine-Service] #6666: Clean up VCH Management API robot tests~~

Known bugs:

~~Adjust VCH creation API to default to resource pool (not vApp) #6526: Adjust VCH creation API to default to resource pool~~
~~Ensure VCH creation log streaming handles concurrent creation operations #6612: Ensure VCH creation log streaming handles concurrent creation operations~~
~~[specific ci=Group23-VIC-Machine-Service] Format VCH creation log API response to text/plain #6640: Format VCH creation log API response to text/plain~~
~~VCH creation API leaves certificate files on disk #6650: VCH creation API leaves certificate files on disk~~
~~Revert change to PUBLIC_NETWORK variable [full ci] #6669: Revert change to PUBLIC_NETWORK variable~~
~~VCH Creation API: Decide what to do if RoutingDestinations is empty #6715: VCH Creation API: Decide what to do if RoutingDestinations is empty~~
~~VCH Creation API: handle registry blacklist #6713: VCH Creation API: handle registry blacklist~~
~~VCH Management APIs: Use the correct IP when determining docker host and admin portal addresses #6728: VCH Management APIs: Use the correct IP when determining docker host and admin portal addresses~~
VCH Management APIs: Ensure VCH creation log read/write does not assume relationship between image store path and VM path #6729: VCH Management APIs: Ensure VCH creation log read/write does not assume relationship between image store path and VM path [ship stopper]
Ensure VCH creation log streaming flushes all data before exiting #6732: Ensure VCH creation log streaming flushes all data before exiting
~~Handle IP ranges in the API like in the CLI [specific ci=Group23-VIC-Machine-Service] #6747: Handle IP ranges in the API like in the CLI~~
~~vic-machine-server image does not include ISOs #6761: vic-machine-server image does not include ISOs~~

Known debt:

Extract constants for magic values [specific ci=Group23-VIC-Machine-Service] #6718: Extract constants for magic values (in review)
~~Minor adjustments to formatting #6719: Minor adjustments to formatting~~
~~Include issue numbers with TODOs #6720: Include issue numbers with TODOs~~
~~Clarify comment in common code for API handlers #6721: Clarify comment in common code for API handlers~~
~~Cleanup build process for vic-machine-server #6723: Cleanup build process for vic-machine-server~~
VCH Creation Log APIs: simplify getAllLogFilePaths #6733: VCH Creation Log APIs: simplify getAllLogFilePaths

Believe to be out-of-scope for 1.3:

Design:
- Design versioning scheme for the REST API #6142: Design versioning scheme for the REST API
- Design pagination scheme for the REST API #6143: Design pagination scheme for the REST API
Testing:
- Implement end-to-end tests for the API handler for getting the creation logs for a VCH #6025: Implement end-to-end tests for the API handler for getting the creation logs for a VCH
- Implement unit tests for the API handler for getting the docker host certificate for a VCH #6021:Implement unit tests for the API handler for getting the docker host certificate for a VCH
- Implement unit tests for the API handler for getting the creation logs for a VCH #6024: Implement unit tests for the API handler for getting the creation logs for a VCH
- Implement unit tests for the API handler for listing VCHs #6027: Implement unit tests for the API handler for listing VCHs
- Implement unit tests for the API handler for inspecting a VCH #6030: Implement unit tests for the API handler for inspecting a VCH
- Implement end-to-end tests for the API handler for inspecting a VCH #6031: Implement end-to-end tests for the API handler for inspecting a VCH
Bug:
- VCH Creation API: Ensure an ID can be used to specify any valid type of compute resource #6711: VCH Creation API: Ensure an ID can be used to specify any valid type of compute resource
- VCH Management APIs: Support concurrent read/write access to the VCH creation log #6730: VCH Management APIs: Support concurrent read/write access to the VCH creation log
Debt:
- Refactor API handlers and vic-machine code to clarify the relationship between CLI, API, and shared code #6032: Refactor API handlers and vic-machine code to clarify the relationship between CLI and API
- Convert vic-machine API swagger definition to YAML #6467: Convert vic-machine API swagger definition to YAML
- VCH Creation API: Move VCH name validation logic from handler to swagger #6710: VCH Creation API: Move VCH name validation logic from handler to swagger
- VCH Management APIs: Properly handle ImageStore #6712: VCH Management APIs: Properly handle ImageStore
- VCH Inspect API: Properly handle unexpected PKI material #6716: VCH Inspect API: Properly handle unexpected PKI material
- VCH Inspect API: Handle references to objects which cannot be found #6717: VCH Inspect API: Handle references to objects which cannot be found

mdubya66

All licenses are ok Approved for vendor changes.

mhagen-vmware

lgtm, nicely done

anchal-agrawal · 2017-11-07T19:34:03Z

cmd/vic-machine/common/target.go

@@ -76,6 +77,12 @@ func (t *Target) HasCredentials() error {
 		return cli.NewExitError("--target argument must be specified", 1)
 	}

+	// assume if a vsphere session key exists, we want to use that instead of user/pass
+	if t.CloneTicket != "" {
+		t.URL.User = nil // necessary?


Is this necessary?

anchal-agrawal · 2017-11-07T19:35:16Z

lib/apiservers/service/restapi/handlers/common.go

+	if err != nil {
+		return nil, fmt.Errorf("Validation Error: %s", err)
+	}
+	// If dc is not set, and multiple datacenter is available, vic-machine ls will list VCHs under all datacenters.


s/datacenter is/datacenters are

Fix in #6721

anchal-agrawal · 2017-11-07T19:35:53Z

lib/apiservers/service/restapi/handlers/common.go

+	// If dc is not set, and multiple datacenter is available, vic-machine ls will list VCHs under all datacenters.
+	validator.AllowEmptyDC()
+
+	_, err = validator.ValidateTarget(ctx, d)


This error block can be collapsed.

Fix in #6719

anchal-agrawal · 2017-11-07T19:36:09Z

lib/apiservers/service/restapi/handlers/common.go

+	if err != nil {
+		return nil, fmt.Errorf("Target validation failed: %s", err)
+	}
+	_, err = validator.ValidateCompute(ctx, d, false)


This error block can be collapsed.

Fix in #6719

anchal-agrawal · 2017-11-07T19:36:55Z

lib/apiservers/service/restapi/handlers/common.go

+		return nil, util.NewError(http.StatusNotFound, fmt.Sprintf("Unable to find VCH %s: %s", d.ID, err))
+	}
+
+	err = validate.SetDataFromVM(validator.Context, validator.Session.Finder, vch, d)


This error block can be collapsed.

Declining to fix (same explanation as #6694 (comment))

anchal-agrawal · 2017-11-07T19:53:55Z

lib/apiservers/service/restapi/handlers/vch_log_get.go

+
+// getDatastoreHelper validates the VCH and returns the datastore helper for the VCH. It errors when validation fails or when datastore is not ready
+func getDatastoreHelper(op trace.Operation, d *data.Data) (*datastore.Helper, error) {
+	// TODO (angiew): abstract some of the boilerplate into helpers in common.go


👍 for TODO (username)

Issue filed to track TODO, reference added in #6720

anchal-agrawal · 2017-11-07T19:56:53Z

lib/install/management/create.go

@@ -125,7 +137,7 @@ func (d *Dispatcher) uploadImages(files map[string]string) error {
 					switch err.(type) {
 					// if not found, do nothing
 					case object.DatastoreNoSuchFileError:
-					// otherwise force delete
+						// otherwise force delete


This comment seems out of place - it'd fit better inside the default block since that's what the comment is for.

Fixed in #6719

anchal-agrawal · 2017-11-07T19:57:09Z

lib/install/management/create.go

@@ -125,7 +137,7 @@ func (d *Dispatcher) uploadImages(files map[string]string) error {
 					switch err.(type) {
 					// if not found, do nothing


This comment seems out of place - it'd fit better inside the case object.DatastoreNoSuchFileError: block since that's what the comment is for.

Fixed in #6719

anchal-agrawal · 2017-11-07T20:04:35Z

pkg/version/version.go

@@ -101,6 +101,10 @@ func (v *Build) String() string {
 }

 func (v *Build) ShortVersion() string {
+	if v == nil {


Don't think this is needed - if v were indeed nil we'd get a SIGSEGV in the caller.

Instead, we can say:

if v.Version == "" && v.BuildNumber == "" && v.GitCommit == "" { return "unknown" }

If v is nil, we get "unknown".

https://play.golang.org/p/A5t_Ad_q_a

Interesting - TIL! I found this thread with some discussion: https://groups.google.com/forum/#!topic/golang-nuts/wcrZ3P1zeAk.

cc @matthewavery since we were discussing this in person earlier.

anchal-agrawal · 2017-11-07T20:06:13Z

pkg/vsphere/session/session.go

@@ -202,6 +204,7 @@ func (s *Session) Connect(ctx context.Context) (*Session, error) {
 	}

 	soapClient := soap.NewClient(soapURL, s.Insecure)
+


Minor: unneeded whitespace.

I'm going to ignore this to avoid further churn in this file.

This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR vmware#6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances vmware#6262

hickeng

Some items that must be changed. Other comments are informational or left to your discretion - ping me directly for exposition on specific items.

hickeng · 2017-11-08T00:14:12Z

Makefile

@@ -365,7 +384,7 @@ $(appliance-staging): isos/appliance-staging.sh $(iso-base)
 	@$(TIME) $< -c $(BIN)/.yum-cache.tgz -p $(iso-base) -o $@

 # main appliance target - depends on all top level component targets
-$(appliance): isos/appliance.sh isos/appliance/* isos/vicadmin/** $(vicadmin) $(vic-init) $(portlayerapi) $(docker-engine-api) $(appliance-staging)
+$(appliance): isos/appliance.sh isos/appliance/* isos/vicadmin/** $(vicadmin) $(vic-init) $(portlayerapi) $(serviceapi-server) $(docker-engine-api) $(appliance-staging)


I don't think this is the appliance you think it is - this is the VCH endpoint ISO target and definitely doesn't have a dependency on the serviceapi.

Fixed in #6723

hickeng · 2017-11-08T00:16:21Z

Makefile

+	@rm -f ./lib/apiservers/service/restapi/doc.go
+	@rm -f ./lib/apiservers/service/restapi/embedded_spec.go
+	@rm -f ./lib/apiservers/service/restapi/server.go
+	@rm -rf ./lib/apiservers/service/restapi/operations/


Should you have ./lib/apiservers/service/client and ./lib/apiservers/service/models in the list of directories to be removed?

Fixed in #6723

hickeng · 2017-11-08T00:20:42Z

cmd/vic-machine/common/target.go

@@ -76,6 +77,12 @@ func (t *Target) HasCredentials() error {
 		return cli.NewExitError("--target argument must be specified", 1)
 	}

+	// assume if a vsphere session key exists, we want to use that instead of user/pass
+	if t.CloneTicket != "" {
+		t.URL.User = nil // necessary?


Is this necessary?

Good question. Hoping to get an answer here: #6665 (comment)

hickeng · 2017-11-08T00:23:07Z

cmd/vic-machine/common/target.go

+	User        string
+	Password    *string
+	CloneTicket string
+	Thumbprint  string `cmd:"thumbprint"`


I'm unclear why this is being added to the vic-machine command without an option by which to set it.

@jzt may be able to provide more context, but my assumption is that this is essentially due to the poorly defined separation of responsibilities we have between the CLI code and the API and undue coupling between the CLI code and the code it calls.

I'd propose we attempt to clean this up as a part of #6032.

hickeng · 2017-11-08T00:48:39Z

lib/install/management/create.go

@@ -37,6 +38,7 @@ const (
 	uploadMaxElapsedTime  = 30 * time.Minute
 	uploadMaxInterval     = 1 * time.Minute
 	uploadInitialInterval = 10 * time.Second
+	timeFormat            = "2006-01-02T15:04:05-0700"


Should be in lib/constants for consistent reference across components.

I'll add this change to #6718.

Decided to handle separately: #6818

hickeng · 2017-11-08T04:15:50Z

lib/apiservers/service/restapi/handlers/vch_get.go

+	}
+	model.Runtime.PowerState = string(powerState)
+
+	if public := vchConfig.ExecutorConfig.Networks["public"]; public != nil {


This is not correct.
See https://github.com/vmware/vic/blob/master/cmd/docker/main.go#L224 for the port choice logic.

The API is always served on the client network role (unless something is very wrong with current vic-machine) which MAY share an interface with the public network role.

Filed #6728 for this.

hickeng · 2017-11-08T04:23:16Z

lib/apiservers/service/restapi/handlers/vch_log_get.go

+		return operations.NewGetTargetTargetVchVchIDLogDefault(util.StatusCode(err)).WithPayload(err.Error())
+	}
+
+	return operations.NewGetTargetTargetVchVchIDLogOK().WithPayload(output)


I take it this is NOT expected to stream the log? Is it expected to block or truncate at whatever is the end-of-file when we're reading it?

Correct. The proposal is to eventually use a more appropriate protocol (WebSockets?) to allow for streaming of logs. (See #6702 for more information.)

hickeng · 2017-11-08T04:35:59Z

lib/apiservers/service/restapi/handlers/vch_log_get.go

+		return nil, util.NewError(http.StatusNotFound, fmt.Sprintf("Unable to find VCH %s: %s", d.ID, err))
+	}
+
+	if err := validate.SetDataFromVM(validator.Context, validator.Session.Finder, vch, d); err != nil {


There is a vch.FolderName method that you could call that tells you the directory name of the VM.
It looks like that has been recently changed to only provide the Base name - I am unsure why and @caglar10ur has just left. However this is the call used in lib/install/management/appliance.go:523.

The ImageStores path MAY be the same, but should not be in the case of vSAN - a VM in vSAN MUST have a dedicated namespace and I believe we place the image VMDKS into their own namespace.

Filed #6729 for this.

hickeng · 2017-11-08T04:41:46Z

lib/apiservers/service/restapi/handlers/vch_log_get.go

+
+// getAllLogFilePaths returns a list of all log file paths under datastore folder, errors out when no log file found
+func getAllLogFilePaths(op trace.Operation, helper *datastore.Helper) ([]string, error) {
+	res, err := helper.Ls(op, "")


If you look at the implementation of helper.Ls it would be trivial to change it so that you can actually provide a pattern instead of a static name. There is already a MatchPattern defined as part of the search spec.
That would basically eliminate the need for this function.

Filed #6733 for this.

hickeng · 2017-11-08T04:48:27Z

lib/apiservers/service/restapi/handlers/vch_log_get.go

+	sort.Strings(paths)
+
+	for _, p := range paths {
+		reader, err := helper.Download(op, p)


This will not be able to access the file if it is open via a different process (for example still being uploaded) if not accessed via the same host. I do not know if this is an issue or not.
If it is then a specific host can be chosen for the operation by setting a target host in the context: c.vm.Datastore.HostContext(op, h)
See

vic/lib/portlayer/exec/container.go

Line 525 in 0050c58

ctx = c.vm.Datastore.HostContext(ctx, h)

for usage.

Filed #6730 for this.

hickeng · 2017-11-08T04:53:46Z

I've not run through the test code but have done a first pass on the rest of it (high level correctness and flow rather than low level detail).

This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR vmware#6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances vmware#6262

This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR #6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances #6262

Include issue numbers with all TODOs added as a part of the initial VCH creation API project, as suggested during review of the merge commit for the VCH creation API feature branch.

Clarify an unclear comment identified during review of the merge commit for the VCH creation API feature branch.

Remove the serviceapi target as a dependency for the appliance.iso and ensure all generated code is cleaned up.

Introduce a pair of handlers for deleting VCHs within a vSphere target or datacenter. By default, deletion includes the VCH and powered off containers. Deletion may optionally include powered on containers and/or volume stores as well. If any containers remain, the VCH is not deleted. If the VCH is not deleted, the response includes a non-2xx status code. Define a suite of end-to-end tests which verify the intended deletion behavior. End-to-end tests do not attempt to verify the behavior of concurrent operations.

Registry blacklist functionality was designed, but has not been fully implemented in the engine. Remove references to it from the API.

When creating a VCH via the API, we should not write key/certificate files to the API server's disk. This change introduces the behavior as a flag so that it could be exposed as an option for the CLI at some point in the future, but does not expose it at this time.

The vic-machine CLI has differing requirements for gateway routing information, depending on the type of network. According to the CLI help: - a client gateway must specify one or more routing destinations - a public gateway must not specify any routing destinations - a management gateway must specify one or more routing destinations - a container gateway must specify exactly one routing destination This does not seem to be enforced in code, and may simply be more of a suggestion about how these gateways should be used than a requirement. Update the parsing for client, public, and management to support all zero or more routing destinations in all cases; defer to the existing ProcessNetwork code to ensure consistent validation behavior now and in the future. Additionally update the parsing for container to provide a clear error message if the expected routing destination is not supplied.

The vic-machine CLI requires that static addresses are specified as a CIDR, which allows the static address and subnet mask to be supplied in a compact way on the command line. This pattern does not allow for static addresses to be expressed in terms of a hostname. Update the API to match this convention. We may wish to allow for more flexibility in the API in the future, but there's value in at least starting with consistent behavior.

The vic-machine CLI allows IP ranges to be expressed in CIDR notation or as simple ranges in some places, but requires that CIDR notation be used in others. Initially there was a hope of making the API behave more consistently, but that requires changes to underlying logic (some of which is not well covered by existing tests). For now, be consistent with the CLI.

The vic-machine CLI supports specifying a "trust level" for each container network using the --container-network-firewall option. Support the same functionality in the API. Additionally, fix a small bug with the way ip ranges are returned by the inspect API.

Use the client network address, not the public network address, when displaying the admin portal URI and the docker host information as a part of API responses. Additionally, eliminate code duplication.

Additionally, move the binary to a subdirectory of opt to allow the ISO files to be packaged with it. See also: * http://www.tldp.org/LDP/Linux-Filesystem-Hierarchy/html/opt.html

Log each request and response to a configurable destination. Use trace.Operation to associate the request and response information with the logs for the handler to allow for easy debugging, even when there are several requests being handled concurrently. Adjust logging in server's main.go to avoid printing to stdout. Relies on external configuration for log rotation.

zjs · 2017-11-20T08:55:18Z

(note to self)

Interesting CI runs:

ad673c0
- https://ci.vcna.io/vmware/vic/14867 (push)
- https://ci.vcna.io/vmware/vic/14868 (pr)
  - 1 failure in 1-10-Docker-PS, Docker ps last container, is a known issue (docker ps -l did not report the last container created #6676)
  - 27+ failures (5+1+15+6) in 6-* due to "Failed to log in to 192.168.31.54: ServerFaultCode: Cannot complete login due to an incorrect user name or password."
  - ... (still running)
  - Expected: 4 failures in 6-17-Configure-TLS due to the log format change
dc30dd0 (includes fix for 4 failures in 6-17-Configure-TLS)
- https://ci.vcna.io/vmware/vic/14869 (push)
- https://ci.vcna.io/vmware/vic/14876 (pr [forced])
  - 2 failure in 1-11-Docker-RM, which are a known issue (docker ps -l did not report the last container created #6676)
  - ... (still running)

For each conceptual vic-machine operation, create a trace.Operation with an operation-local logger. Emit log messages using the log methods on the operation instead of logrus global methods. This will write to the vic-machine.log using the global trace.Logger and to the user using the operation-local logger. This ensures that both the CLI and API can print log messages to both a local file and the user (via a TTY, if the CLI, and the datastore). * In the CLI, use the operation-local logger to print to the console (using the default Logrus TTY formatting) and write to both the datastore and vic-machine.log file with the global trace.Logger (using VIC's custom log formatter). * In the API, use the the operation-local logger to write to the datastore and write to the server's console with the global trace.Logger. In both cases, use VIC's custom log formatter. Update code in packages used by vic-machine to accept a context, coerce/convert it into a trace.Operation, and use its log methods. Improve readability of logs for concurrent operations by including a operation/context in trace.Begin calls when one is available. Retain configuration for the global logrus logger in vic-machine so that we "fail ugly" (i.e., have lines with mismatched log formats) on the CLI if something uses the old pattern, but don't lose information. Update tests which parse log messages to understand this new format instead of or, where necessary, in addition to old format(s).

Define a new VCH Management API and implement the subset of that API which is necessary for building a VCH Creation Wizard as a part of the H5 Client Plugin.

This commit makes the 'Remove a container and its anonymous volume' test case more robust by force-removing the container that runs the /bin/ls command, since it's possible for the container to not have powered off fully and the container state to not have updated to 'Stopped' before the remove command is issued in the test. Before this change, it was possible for the test to fail if the container state wasn't updated on time. This was seen in CI build 14551 for PR vmware#6665. Since that test snippet's intent (verify that the anonymous volume can be used by a new container) is unaffected by how the container is removed, this change is valid. Enhances vmware#6262

zjs self-assigned this Oct 31, 2017

zjs requested review from hickeng and mhagen-vmware October 31, 2017 17:22

vmwclabot added the cla-not-required label Oct 31, 2017

zjs force-pushed the feature/vic-machine-service branch from e2957ac to 66411cf Compare October 31, 2017 23:19

mdubya66 approved these changes Nov 4, 2017

View reviewed changes

mhagen-vmware approved these changes Nov 6, 2017

View reviewed changes

andrewtchin approved these changes Nov 6, 2017

View reviewed changes

zjs force-pushed the feature/vic-machine-service branch 6 times, most recently from 2d7026a to 99035e4 Compare November 7, 2017 01:23

anchal-agrawal reviewed Nov 7, 2017

View reviewed changes

anchal-agrawal mentioned this pull request Nov 7, 2017

[specific ci=1-11-Docker-RM] Force remove container in 1-11-Docker-RM test #6708

Merged

This was referenced Nov 8, 2017

Extract constants for magic values [specific ci=Group23-VIC-Machine-Service] #6718

Merged

Minor adjustments to formatting #6719

Closed

Include issue numbers with TODOs #6720

Merged

Clarify comment in common code for API handlers #6721

Merged

hickeng requested changes Nov 8, 2017

View reviewed changes

This was referenced Nov 8, 2017

Cleanup build process for vic-machine-server #6723

Merged

Refactor API handlers and vic-machine code to clarify the relationship between CLI, API, and shared code #6032

Open

zjs and others added 14 commits November 20, 2017 00:14

Include issue numbers with TODOs

462eceb

Include issue numbers with all TODOs added as a part of the initial VCH creation API project, as suggested during review of the merge commit for the VCH creation API feature branch.

Clarify comment in common code for API handlers

d03c730

Clarify an unclear comment identified during review of the merge commit for the VCH creation API feature branch.

Cleanup build process for vic-machine-server

861d880

Remove the serviceapi target as a dependency for the appliance.iso and ensure all generated code is cleaned up.

VCH Management API: Remove registry blacklist

53d7623

Registry blacklist functionality was designed, but has not been fully implemented in the engine. Remove references to it from the API.

List client address for accessing services in API

26fb427

Use the client network address, not the public network address, when displaying the admin portal URI and the docker host information as a part of API responses. Additionally, eliminate code duplication.

Include ISO files in server docker image

959bcd4

Additionally, move the binary to a subdirectory of opt to allow the ISO files to be packaged with it. See also: * http://www.tldp.org/LDP/Linux-Filesystem-Hierarchy/html/opt.html

Add unit tests for VCH create (#6764)

1d6656b

zjs force-pushed the feature/vic-machine-service branch 5 times, most recently from 50d22de to e47dfcb Compare November 20, 2017 08:52

zjs force-pushed the feature/vic-machine-service branch from e47dfcb to ad673c0 Compare November 20, 2017 09:10

zjs force-pushed the feature/vic-machine-service branch 3 times, most recently from 110545c to dc30dd0 Compare November 20, 2017 13:19

zjs merged commit dc30dd0 into master Nov 20, 2017

zjs added a commit that referenced this pull request Nov 20, 2017

Merge branch 'feature/vic-machine-service' (#6665)

ceb9a4b

Define a new VCH Management API and implement the subset of that API which is necessary for building a VCH Creation Wizard as a part of the H5 Client Plugin.

zjs mentioned this pull request Nov 21, 2017

Centralize time formatting in datastore log naming [specific ci=Group23-VIC-Machine-Service] #6818

Merged

andrewtchin deleted the feature/vic-machine-service branch February 21, 2018 18:28

		@@ -125,7 +137,7 @@ func (d *Dispatcher) uploadImages(files map[string]string) error {
		switch err.(type) {
		// if not found, do nothing

		@@ -202,6 +204,7 @@ func (s Session) Connect(ctx context.Context) (Session, error) {
		}

		soapClient := soap.NewClient(soapURL, s.Insecure)

Merge branch 'feature/vic-machine-service' [full ci] #6665

Merge branch 'feature/vic-machine-service' [full ci] #6665

Conversation

zjs commented Oct 31, 2017 • edited Loading

mdubya66 left a comment

Choose a reason for hiding this comment

mhagen-vmware left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hickeng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zjs Nov 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zjs Nov 8, 2017 • edited Loading

Choose a reason for hiding this comment

hickeng commented Nov 8, 2017

zjs commented Nov 20, 2017 • edited Loading

zjs commented Oct 31, 2017 •

edited

Loading

zjs Nov 8, 2017 •

edited

Loading

zjs Nov 8, 2017 •

edited

Loading

zjs commented Nov 20, 2017 •

edited

Loading