Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10 & 11 Ready #105

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Windows 10 & 11 Ready #105

merged 1 commit into from
Apr 7, 2023

Conversation

quirogas
Copy link
Contributor

@quirogas quirogas commented Apr 5, 2023

  • Fix issue where 'psutil' to version 5.9.4 to prevent dependency on a template to crash build
  • Standardize encoding of properties file to 'utf-8' to prevent encoding errors on Windows

Before:

image

After:

image

@quirogas quirogas self-assigned this Apr 5, 2023
@quirogas quirogas requested a review from kjrokos April 6, 2023 15:21
kjrokos
kjrokos reviewed Apr 6, 2023
View reviewed changes
vmware_aria_operations_integration_sdk/mp_init.py
@@ -427,7 +427,7 @@ def build_project_structure(
# create template requirements.txt
requirements_file = os.path.join(path, "adapter_requirements.txt")
with open(requirements_file, "w") as requirements:
requirements.write("psutil==5.9.0\n")
requirements.write("psutil==5.9.4\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed this was an issue recently but didn't look into it at the time. Do you know what caused the older version to stop working? (Was it from when we updated the base OS image?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue seems related to gcc, so we could've updated gcc in the base image. However, version 5.9.4 implemented a feature that appears to be a better overall fix for the future, so I went with it. However, we might want to give a deeper look at this in the future.

@quirogas quirogas merged commit 46b3c45 into main Apr 7, 2023
@quirogas quirogas deleted the bug/windows-ready branch May 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkArbogast MarkArbogast MarkArbogast approved these changes

@kjrokos kjrokos kjrokos approved these changes

Assignees

@quirogas quirogas

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quirogas @MarkArbogast @kjrokos @vmwclabot