Always stop timers when exiting the 'Timer.time' block #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, throwing an exception inside the Timer.time() function block would cause the running timer to continue outside of the block.
This change does two things:
@Throws
annotation to the function block so Java code calling this method is also allowed to throw checked exceptions. Previously Java code could only throw unchecked exceptions, while Kotlin code was able to throw any exception. This brings the functionality closer to parity.Resolves #361