better error handling in create resources apiclient methods

apiclient/errors.go

@@ -27,4 +27,6 @@ var (
 	// ErrDecodingResponse is returned when there is an error decoding the response
 	// from the API. The response is decoded from JSON and this process can fail.
 	ErrDecodingResponse = fmt.Errorf("error decoding response")
+	// ErrAlreadyExists is returned when the resource already exists
+	ErrAlreadyExists = fmt.Errorf("resource already exists")
 )

apiclient/strategies.go

@@ -239,7 +239,12 @@ func (c *HTTPclient) CreateStrategy(request *api.Strategy) (uint64, error) {
 			log.Errorf("error closing response body: %v", err)
 		}
 	}()
-	if res.StatusCode != http.StatusAccepted {
+	switch res.StatusCode {
+	case http.StatusAccepted, http.StatusOK:
+		break
+	case http.StatusConflict:
+		return 0, ErrAlreadyExists
+	default:
 		return 0, fmt.Errorf("%w: %s", ErrNoStatusOk,
 			fmt.Errorf("%d %s", res.StatusCode, http.StatusText(res.StatusCode)))
 	}

apiclient/tokens.go

@@ -121,10 +121,14 @@ func (c *HTTPclient) CreateToken(token *api.Token) error {
 			log.Errorf("error closing response body: %v", err)
 		}
 	}()
-	if res.StatusCode != http.StatusCreated && res.StatusCode != http.StatusOK && res.StatusCode != http.StatusConflict {
+	switch res.StatusCode {
+	case http.StatusCreated, http.StatusOK:
+		return nil
+	case http.StatusConflict:
+		return ErrAlreadyExists
+	default:
 		return fmt.Errorf("%w: %w", ErrNoStatusOk, fmt.Errorf("%d %s", res.StatusCode, http.StatusText(res.StatusCode)))
 	}
-	return nil
 }
 
 // DeleteToken method deletes a token in the API, it accepts the tokenID,