Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: gfan-0.6.2 #34182

Merged
merged 1 commit into from
Nov 22, 2021
Merged

New package: gfan-0.6.2 #34182

merged 1 commit into from
Nov 22, 2021

Conversation

tornaria
Copy link
Contributor

Dependency of sagemath

@paper42 paper42 added the new-package This PR adds a new package label Nov 21, 2021
@tornaria
Copy link
Contributor Author

It seems to be stuck in a test on i686. On my box the test that stalls is:

Running command:"cat <testsuite/0602ResultantFanProjection/input|./gfan _resultantfan --vectorinput --projection| grep F_VECTOR -A1>testsuite/0602ResultantFanProjection/outputNew"

The whole testsuite takes ~ 1m on x86_64 and the test above has been running for 6m+ on my box (and apparently it ran 1h30 on CI).

@tornaria
Copy link
Contributor Author

Summary: two tests fail on i686:

testsuite/0009RenderStairCase FAILED!
testsuite/0602ResultantFanProjection FAILED!

The first one finishes with failure, and the second one doesn't finish. I'll report them both upstream later.

@leahneukirchen: Do you think we have to delay merging b/c of this? I'll follow up in any case.

@leahneukirchen
Copy link
Member

I don't mind the test suite failure, but this sounds like it's actually broken on i686 so fixing would be good.

Perhaps someone can try on 32-bit ARM?

@tornaria
Copy link
Contributor Author

I don't mind the test suite failure, but this sounds like it's actually broken on i686 so fixing would be good.

Sure, but since only one particular application is broken maybe this is still useful. Otherwise we could not package for 32 bits.

@ericonr
Copy link
Member

ericonr commented Nov 21, 2021

Suggested on IRC: have you tried adding -ffloat-store to the x86 build to see if it's enough?

@tornaria
Copy link
Contributor Author

Suggested on IRC: have you tried adding -ffloat-store to the x86 build to see if it's enough?

Indeed, this fixes the failure in 0009RenderStairCase so I'll add it. Unfortunately, 0602ResultantFanProjection is still looping forever regardless of this option.

@tornaria
Copy link
Contributor Author

I couldn't find an issue tracker for gfan. On the sagemath trac, the same issue was reported 5 months ago in https://trac.sagemath.org/ticket/32088, but there is no clue there.

@tornaria
Copy link
Contributor Author

Also debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905300. They just disable this test on 32bit.

@tornaria
New package: gfan-0.6.2
2c5be10 
Uses three patches taken from sagemath, cf
https://git.sagemath.org/sage.git/plain/build/pkgs/gfan/patches?h=9.5.beta7

 - fix location of cddlib include files
 - normalize the output of one failing test
 - make tests return an error so build aborts

Also fixes for 32 bit bugs catched by testsuite:
 - add `-ffloat-store` to CFLAGS to fix `0009RenderStairCase`
 - patch typedef for `int64` which causes hang in `0602ResultantFanProjection`
@tornaria tornaria mentioned this pull request Nov 22, 2021
Closed
@leahneukirchen leahneukirchen merged commit 290d0ac into void-linux:master Nov 22, 2021
@tornaria tornaria deleted the gfan branch November 22, 2021 12:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tornaria @leahneukirchen @ericonr @paper42