-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: zed-0.156.1 #50476
base: master
Are you sure you want to change the base?
New package: zed-0.156.1 #50476
Conversation
ah also, checks will fail. For some reasons the checks require a certain font to be install, on the IRC (thanks to the ones who helped me, you guys rock) we made tests with |
Also i noted the duplicate (#49019 (comment)) but i'm willing to continue the great work made by the original request author. To the author, your work helped me a lot for this, thank you. |
4c35402
to
90070ed
Compare
d616191
to
2df8165
Compare
36c4d9b
to
964fadc
Compare
964fadc
to
b13f4df
Compare
template dir and pkgname should be the same case |
wait i forgot to upload my new template, my mistake.. It should be better in a while |
6adce2f
to
0f9e28a
Compare
|
okay found it: |
PR made at upstream: zed-industries/zed#12218 |
|
If |
TryExec does serve a purpose, don't remove it, just fix the case |
yep, it's done. |
f488718
to
c097eb8
Compare
710d8fc
to
cb27ab5
Compare
cb27ab5
to
ce0a734
Compare
Any idea why the aarch64 build fails ? It looks like mold's presence and llvm regardless of the versions, don't help... |
Just patch [build]
# v0 mangling scheme provides more detailed backtraces around closures
rustflags = ["-C", "symbol-mangling-version=v0", "--cfg", "tokio_unstable"]
[alias]
xtask = "run --package xtask --"
-[target.x86_64-unknown-linux-gnu]
-linker = "clang"
-rustflags = ["-C", "link-arg=-fuse-ld=mold"]
-[target.aarch64-unknown-linux-gnu]
-linker = "clang"
-rustflags = ["-C", "link-arg=-fuse-ld=mold"]
# This cfg will reduce the size of `windows::core::Error` from 16 bytes to 4 bytes
[target.'cfg(target_os = "windows")']
rustflags = ["--cfg", "windows_slim_errors"] Relevant PR: zed-industries/zed#12944 If you want to continue using clang, you might need to have the |
if you want to use clang, it will need to go in hostmakedepends currently it is only in makedepends, as it is being pulled in by llvm18-devel |
I guess, Except if we have a reason not to use clang, we can always add it ? Or should i take the minimalist route and get rid of it? What would be the preferred choice for void maintainers? EDIT: also if llvm18-devel pulls clang, if i need clang in hostmakedepends, can i just move llvm18-devel there? Or should I pull clang entirely? |
I don't see a reason not to. it's simpler to include clang and mold rather than to patch it out. probably improves build times quite a bit. gnu ld is very slow compared to mold, especially when linking large static binaries (rust)
I'm not a maintainer, this is my personal opinion: void is not a "minimal" distro. having clang in hostmakedepends is fine.
If clang is only needed as a compiler, it's best to simply put its possible that zed does need llvm, in that case you would put back |
ce0a734
to
75cc7cf
Compare
Btw how does zed look so far? Would it be suitable for void repos as of today? |
again, I'm not a maintainer, this is my personal opinion: zed is unacceptable until they fix the "downloads binaries without the user's consent" issue |
That's understandable tbf, even though i'm not completely aware of the issue and its details as of now... Is it through the extension? |
|
Damn so that was it! I thought it was a false positive (and it is in a way) but it's zed doing stuff in the background...! |
75cc7cf
to
6946f76
Compare
6946f76
to
4f74de6
Compare
57bc174
to
b94525c
Compare
I added cmake to the
|
58c8c5c
to
b63f9aa
Compare
b63f9aa
to
f5afa56
Compare
f5afa56
to
b8ce584
Compare
Testing the changes
New package
Local build testing
Just me making a PR for Zed, it's evolving fast, the PR is not ready, but the template does work. This PR's purpose is for others to keep track of the tests i'm doing.
Take care, i'm all ears for suggestions of course. ✌️